[SECURITY_SOLUTION] adjust policy onboarding view, check for Ingest permissions #70536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…na into task/onboarding-ux-updates
kevinlog
changed the title
kevinlog
added
release_note:skip
| /> | ||
| } | ||
| bodyComponent={ | ||
| <FormattedMessage | ||
| id="xpack.securitySolution.endpoint.endpointList.noEndpointsInstructions" | ||
| defaultMessage="Elastic Endpoint Security gives you the power to keep your endpoints safe from attack, as well as unparalleled visibility into any threat in your environment." | ||
| defaultMessage="You’ve created your security policy. Now you need to enable the Elastic Endpoint Security capabilities on your agents following the steps below. For additional information, view our ‘getting started guide’." |
There was a problem hiding this comment.
what the abbreviation of 've
| dataTestSubj="emptyEndpointsTable" | ||
| steps={policySteps} | ||
| headerComponent={ | ||
| <FormattedMessage | ||
| id="xpack.securitySolution.endpoint.endpointList.noEndpointsPrompt" | ||
| defaultMessage="You have a policy, but no Endpoints are deployed!" | ||
| defaultMessage="Enable Elastic Endpoint Security on your agents" |
There was a problem hiding this comment.
agents? Is something people are expected to know?
| <EuiText size="s" color="subdued"> | ||
| <FormattedMessage | ||
| id="xpack.securitySolution.endpoint.policyList.onboardingSectionTwo" | ||
| defaultMessage="You’ll be able to view and manage hosts in your environment running the Elastic Endpoint from this page." |
There was a problem hiding this comment.
You'll may be You will ?
paul-tavares
reviewed
Jul 8, 2020
| id="xpack.securitySolution.endpoint.policyList.stepThree" | ||
| defaultMessage="If you haven’t already, enroll your agents through Fleet using the same agent configuration." | ||
| id="xpack.securitySolution.endpoint.policyList.placeholdForPictures" | ||
| defaultMessage="Pictures!!!" |
There was a problem hiding this comment.
Suggestion that you use a placeholder pic while the official one is being determined. Maybe:
<EuiIcon type="logoSecurity" size="xl" />
There was a problem hiding this comment.
wasn't planning on merging until I got the asset, but that's a good alternative to keep moving
| }); | ||
|
|
||
| it('should display the No Permissions view when Ingest is OFF', async () => { | ||
| (useIngestEnabledCheck as jest.Mock).mockReturnValue({ allEnabled: false }); |
There was a problem hiding this comment.
Why do you need to cast the useIngestEnabledCheck? You should not have to, so I'm thinking something in the mocked interface is not right.
There was a problem hiding this comment.
you're right that it's not required, was just following other examples - will remove
There was a problem hiding this comment.
I take that back, I remember why now - the tests will run correctly without it, but it fails typecheck
| return ( | ||
| <Switch> | ||
| <Route path={MANAGEMENT_ROUTING_ENDPOINTS_PATH} component={EndpointsContainer} /> | ||
| <Route path={MANAGEMENT_ROUTING_POLICIES_PATH} component={PolicyContainer} /> | ||
| <Route |
There was a problem hiding this comment.
I had been wondering about this. You had mentioned before (maybe standup) that the tab was disabled, but rally, what is happening is that we still show/enable the tab, but display a different page - correct?
Also - Instead of using the conditional below in all <Route>'s, just add one at before this return, so that we don't have to keep writing the condition on each <Route> - like :
const { allEnabled: isIngestEnabled } = useIngestEnabledCheck();
if (!isIngestEnabled) {
return `<Route path="*" component={NoPermissions} />`;
}
return (
<Switch>
<Route path={MANAGEMENT_ROUTING_ENDPOINTS_PATH} component={EndpointsContainer} />
<Route path={MANAGEMENT_ROUTING_POLICIES_PATH} component={PolicyContainer} />
//....There was a problem hiding this comment.
@paul-tavares yes, we do want the tab to still show up, that's an ask from product so that we do not hide newer features. This way users can discover why they are not able to use the feature and adjust permissions accordingly.
There was a problem hiding this comment.
Ok - The issue is on how the mock is defined then. It probably just needs to be adjusted there to something like jest.Mock<Typehere>.
We can address it later (maybe open an issue so we don't forget :) )
paul-tavares
approved these changes
Jul 8, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests should allow creation of lens visualizationsStandard OutStack TraceBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
kevinlog
added a commit
to kevinlog/kibana
that referenced
this pull request
Jul 9, 2020
…ermissions (elastic#70536) * adjust policy onboarding view * correct test subj * fix tests * re-enable tests * add no permissions view * adjust onbording look * adjust text * use ingest hook, add tests * adjust text * address comments * beta badges * fix test * correct timeline flyout Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kevinlog
added a commit
that referenced
this pull request
Jul 9, 2020
|
Pinging @elastic/siem (Team:SIEM) |
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR:
New onboarding screen for No Policy (graphic from designers pending):
New oboarding screen for No Endpoint (docs link pending):
Admin disabled screen:
Checklist
Delete any items that are not applicable to this PR.