Load configuration from EMS-metadata in region-maps #70888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of relying on the vis-state. For EMS-layers, load from EMS-metadata. For self-hosted layers, load from the kibana.yml config.
thomasneirynck
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
changed the title
|
@elasticmachine merge upstream |
kindsun
reviewed
Jul 7, 2020
kindsun
reviewed
Jul 7, 2020
…nck/kibana into maps/load_config_dynamically
legrego
reviewed
Jul 7, 2020
kindsun
approved these changes
Jul 7, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 8, 2020
thomasneirynck
added a commit
that referenced
this pull request
Jul 8, 2020
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 8, 2020
|
I removed v6.8.12 label because it appears this was already in v6.8.11. |
This was referenced Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Region-maps would rely on the
visStateto load the human-readable name and attribution of the EMS. While reading out settings of the visState is the canonical approach in Visualize for settings configured in the UX (e.g. metrics and buckets), region maps should not do this for the layer configurations that get rendered to the screen as-is.This PR makes two changes:
maps.regionmap.layers[].attribution) gets URL-escaped. This parameter is only allowed to be a text-string, as per the existing documentation (https://www.elastic.co/guide/en/kibana/current/settings.html).Blocked by #70992. When that merges, can add appropriate test coverage.