-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve failure reporting output for functional tests #70954
Merged
dej611
merged 4 commits into
elastic:master
from
dej611:functional-tests/better-failing-reports
Jul 9, 2020
Merged
Improve failure reporting output for functional tests #70954
dej611
merged 4 commits into
elastic:master
from
dej611:functional-tests/better-failing-reports
Jul 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
@dej611 is this ready for review? It's still in draft mode but I'm excited to get it. If you're ready click that "ready for review" button :) |
dej611
added
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
v8.0.0
labels
Jul 8, 2020
spalger
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Jul 9, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dej611
added a commit
that referenced
this pull request
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Functional Testing
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains some improvement in case of failures during the functional tests run: in particular when multiple tests are failing the reporter is only showing the number of failures, and to find which test has failed is a process of scrolling the log and look for the "fail" red word.
The alternative method was to use the
--bail
flag to stop at the first failure.The improvement in this PR improves the investigation process by integrating the full error message into the custom reporter from
mocha
and show a short summary of the failures details at the end of the run.This should simplify the process of debugging failing tests.
mocha
error message and format it properlyBefore
Error inline:
mocha
was printing the Error breaking the format in the logger as shown below.Final summary: it shows how many test failed, but not which ones.
After
Error inline: it shows the Error with the right format.
Final summary: after the numbers also details on the name of the failed tests are shown.
Checklist
Delete any items that are not applicable to this PR.