Workplace Search in Kibana MVP #70979

scottybollinger · 2020-07-07T16:12:13Z

Summary

This PR adds a Workplace Search MVP to the Enterprise Search in Kibana plugin

QA

Standard auth

Workplace Search admin page renders and matches http://localhost:3002/ws#/org
Adding a source adds to recent activity at bottom, changes icon to checkmark in onboarding card and updates source count in Usage statistics (custom source is quickest)
Adding a user changes icon to checkmark in onboarding card and updates user count in Usage statistics
Once source has been added, user has been invited, and org name changed, the onboarding sections (sources, users, and org name) should be hidden.
Test for a user that has app search access but not workplace search access (and vice versa)

Native auth
Same as Standard without the users cards

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

cee-chen · 2020-07-09T15:51:08Z

^ I think these are flaky tests unrelated to our code FWIW, a re-run might fix?

scottybollinger · 2020-07-09T15:54:50Z

@elasticmachine merge upstream

cee-chen · 2020-07-09T20:16:13Z

You can now rebase against latest master!!!

scottybollinger · 2020-07-09T20:34:29Z

@elasticmachine merge upstream

elasticmachine · 2020-07-09T20:34:31Z

merge conflict between base and head

- Adds telemetry for Workplace Search - Adds routing for telemetry and overview - Registers plugin

This is the functional MVP for Workplace Search

- Remove saved objects indexing - add schema definition - remove no_ws_account - minor cleanup

- Still not working but fixed the syntax nonetheless

- Was unable to get the `FormattedMessage` to work using the syntax in the docs. Always added ‘more’, even when there were zero (or one for users). This commit uses an alternative approach that works

🤦

Because of a change in the Workplace Search rails code, we can now use non-hash routes that will be redirected by rails so that we don’t have users stuck on the overview page in Workplace Search when logging in

Previously the dashboard in legacy Workplace Search linked to the sources page and this was replicated in the Kibana MVP. This PR aligns with the legacy dashboard directly linking to the source details elastic/ent-search#1688

@scottybollinger

- Pull out iterated activity items into a child subcomponent - Move constants/strings closer to where they're being used, instead of having to jump around the file - Move IActivityFeed definition to this file, since that's primarily where it's used @scottybollinger - if you're not a fan of this commit no worries, just let me know and we can discuss/roll back as needed

- remove unused CSS - fallback cleanup - refactor tests

- Remove unused CSS classes - Refactor tests to include all props/more specific assertions

- Prefer using EuiTextColor to spans / custom classes - Prefer using EuiCard's native `href` behavior over using our own wrapping link/--isClickablec class - Note that when we port the link/destination over to React Router, we should instead opt to use React Router history, which will involve creating a EuiCard helper - Make test a bit more specific

cee-chen

3rd pass - just 3 more components left!! 🎉

Quick note about the removed CSS classes - if they need to be added back at some point for future views, I'd prefer to do it when those are added vs right now, if that's cool

.../applications/workplace_search/components/shared/view_content_header/view_content_header.tsx

...ications/workplace_search/components/shared/view_content_header/view_content_header.test.tsx

...lic/applications/workplace_search/components/shared/content_section/content_section.test.tsx

...h/public/applications/workplace_search/components/shared/content_section/content_section.tsx

...nterprise_search/public/applications/workplace_search/components/overview/statistic_card.tsx

- Use EuiFlexGrid

johnbarrierwilson · 2020-07-11T02:27:46Z

@constancecchen and I just noticed a weird ole bug 🐛 with the setup guide sidebar image/video.

johnbarrierwilson

Only one small change left for CSS stuff on my end!

...erprise_search/public/applications/workplace_search/components/overview/recent_activity.scss

- i18n - Compact i18n newlines (nit) - Convert FormattedMessage to i18n.translate for easier test assertions - Org Name CTA - Move to separate child subcomponent to make it easier to quickly skim the parent container - Remove unused CSS class - Fix/add responsive behavior - Tests refactor - Use describe() blocks to break up tests by card/section - Make sure each card has tests for each state - zero, some/complete, and disabled/no access - Assert by plain text now that we're using i18n.translate() - Remove ContentSection/EuiPanel assertions - they're not terribly useful, and we have more specific elements to check - Add accounts={0} test to satisfy yellow branch line

- Remove unused CSS class - Remove unnecessary template literal Tests - Swap out check for EuiFlexItem - it's not really the content we're concerned about displaying, EuiEmptyPrompt is the primary component - Remove need for mount() by dive()ing into EuiEmptyPrompt (this also removes the need to specify a[data-test-subj] instead of just [data-test-subj]) - Simplify empty button test - previous test has already checked for href/telemetry - Cover uncovered actionPath branch line

- Remove unused telemetry type - Remove unused CSS class - finally - Remove unused license context from tests

cee-chen

OK!! I think that's it, I looked at every file/component!! Pushing up another round of commits addressing my comments, and then another set of minor fixes.

Awesome stuff Scotty - especially your tests. it's been an absolute joy working with you! ✨

For QA, I'm super unfamiliar with setting up Workplace Search so might need help with that if you want me to do a pass on anything on Monday. I can confirm telemetry and plugin access is still working for me at least!

...prise_search/public/applications/workplace_search/components/overview/organization_stats.tsx

...erprise_search/public/applications/workplace_search/components/overview/onboarding_steps.tsx

...gins/enterprise_search/public/applications/workplace_search/components/overview/overview.tsx

cee-chen · 2020-07-11T03:23:11Z

...gins/enterprise_search/public/applications/workplace_search/components/overview/overview.tsx

+        <OrganizationStats {...appData} />
+        <EuiSpacer size="xl" />
+        <RecentActivity {...appData} />


Optional - might consider specifically passing the specific props that the components actually use instead of the entire blob? 🤔 But the lazy dev in me really likes it this way hahaha

cee-chen · 2020-07-11T03:23:49Z

...gins/enterprise_search/public/applications/workplace_search/components/overview/overview.tsx

+          description={headerDescription}
+          action={<ProductButton />}
+        />
+        {!hideOnboarding && <OnboardingSteps {...appData} />}


@scottybollinger Any chance we could upload a screenshot of what the non-onboarding overview page looks like to the PR description?

(Or if you could walk me through that in QA, that would be great!)

...enterprise_search/public/applications/workplace_search/components/overview/overview.test.tsx

cee-chen · 2020-07-11T03:52:39Z

Next batch of non-cleanup fixes coming up!

- Fix setup guide CSS class casing - Remove border transparent (UX > UI)

- Whoops, totally missed this 🤦

- Has to be without_host_configured, since with host requires Enterprise Search - Just checks for basic Setup Guide redirect for now - TODO: Add more in-depth feature/privilege functional tests for both plugins at later date

- Turns out you don't need render(), shallow() skips useEffect already 🤦 - Fix outdated comment import example

+ Minor engines_overview test refactors: - Prefer to define `const wrapper` at the start of each test rather than a `let wrapper` - this better for sandboxing / not leaking state between tests - Move Platinum license tests above pagination, so the contrast between the two tests are easier to grok

cee-chen · 2020-07-11T06:08:18Z

Okay I swear that's it!! 😅 Thanks for putting up with me Scotty, some of the commits are DRY-type stuff that I can potentially pull out into a separate PR if it gets too confusing - hopefully not though (I tried to commit as granularly as possible as you can probably tell hahaa 🤞)

If any of my changes look questionable or aren't to your preference (e.g. some of the refactors/new subcomponents), def feel free to push back - I'm happy to discuss/revert/separate as needed!

johnbarrierwilson

Such awesome work @scottybollinger and @constancecchen!

x-pack/plugins/enterprise_search/README.md

…eature/workplace-search-mvp

- README copy tweak + linting - Remove unused euiCard classes from onboarding card

cee-chen

I think this is good to go once tests pass!! 💦

cee-chen · 2020-07-13T18:15:28Z

🎉 🚢

@scottybollinger

* Add Workplace Search plugin to app - Adds telemetry for Workplace Search - Adds routing for telemetry and overview - Registers plugin * Add breadcrumbs for Workplace Search * Add Workplace Search index * Add route paths, types and shared assets * Add shared Workplace Search components * Add setup guide to Workplace Search * Add error state to Workplace Search * Add Workplace Search overview This is the functional MVP for Workplace Search * Update telemetry per recent changes - Remove saved objects indexing - add schema definition - remove no_ws_account - minor cleanup * Fix pluralization syntax - Still not working but fixed the syntax nonetheless * Change pluralization method - Was unable to get the `FormattedMessage` to work using the syntax in the docs. Always added ‘more’, even when there were zero (or one for users). This commit uses an alternative approach that works * Update readme * Fix duplicate i18n label * Fix failing test from previous commit :facepalm: * Update link for image in Setup Guide * Remove need for hash in routes Because of a change in the Workplace Search rails code, we can now use non-hash routes that will be redirected by rails so that we don’t have users stuck on the overview page in Workplace Search when logging in * Directly link to source details from activity feed Previously the dashboard in legacy Workplace Search linked to the sources page and this was replicated in the Kibana MVP. This PR aligns with the legacy dashboard directly linking to the source details https://github.com/elastic/ent-search/pull/1688 * Add warn logging to Workplace Search telemetry collector * Change casing to camel to match App Search * Misc security feedback for Workplace Search * Update licence mocks to match App Search * PR feedback from App Search PR * REmove duplicate code from merge conflict * Fix tests * Move varible declaration inside map for TypeScript There was no other way 🤦 * Refactor last commit * Add punctuation Smallest commit ever. * Fix actionPath type errors * Update rebase feedback * Fix failing test * Update telemetry test after AS PR feedback * DRY out error state prompt copy * DRY out telemetry endpoint into a single route + DRY out DRY out endpoint - Instead of /api/app_search/telemetry & /api/workplace_search/telemetry, just have a single /api/enterprise_search/telemetry endpoint that takes a product param - Update public/send_telemetry accordingly (+ write tests for SendWorkplaceSearchTelemetry) DRY out helpers - Pull out certain reusable helper functions into a shared lib/ folder and have them take the repo id/name as a param - Move tests over - Remove misplaced comment block +BONUS - pull out content type header that's been giving us grief in Chrome into a constant * Remove unused telemetry type * Minor server cleanup - DRY out mockLogger * Setup Guide cleanup * Clean up Loading component - use EUI vars per feedback - remove unnecessary wrapper - adjust vh for Kibana layout - Actually apply loadingSpinner styles * Misc i18n fixes + minor newline reduction, because prettier lets me * Refactor Recent Activity component/styles - Remove table markup/styles - not semantically correct or accessible in this case - replace w flex - Fix link colors not inheriting - Add EuiPanel, error colors looked odd against page background - Fix prop/type definition - CSS cleanup - EUI vars, correct BEM, don't target generic selectors * [Opinionated] Refactor RecentActivity component - Pull out iterated activity items into a child subcomponent - Move constants/strings closer to where they're being used, instead of having to jump around the file - Move IActivityFeed definition to this file, since that's primarily where it's used @scottybollinger - if you're not a fan of this commit no worries, just let me know and we can discuss/roll back as needed * Refactor ViewContentHeader - remove unused CSS - fallback cleanup - refactor tests * Refactor ContentSection - Remove unused CSS classes - Refactor tests to include all props/more specific assertions * Refactor StatisticCard - Prefer using EuiTextColor to spans / custom classes - Prefer using EuiCard's native `href` behavior over using our own wrapping link/--isClickablec class - Note that when we port the link/destination over to React Router, we should instead opt to use React Router history, which will involve creating a EuiCard helper - Make test a bit more specific * Minor OrganizationStats cleanup - Use EuiFlexGrid * Refactor OnboardingSteps - i18n - Compact i18n newlines (nit) - Convert FormattedMessage to i18n.translate for easier test assertions - Org Name CTA - Move to separate child subcomponent to make it easier to quickly skim the parent container - Remove unused CSS class - Fix/add responsive behavior - Tests refactor - Use describe() blocks to break up tests by card/section - Make sure each card has tests for each state - zero, some/complete, and disabled/no access - Assert by plain text now that we're using i18n.translate() - Remove ContentSection/EuiPanel assertions - they're not terribly useful, and we have more specific elements to check - Add accounts={0} test to satisfy yellow branch line * Clean up OnboardingCard - Remove unused CSS class - Remove unnecessary template literal Tests - Swap out check for EuiFlexItem - it's not really the content we're concerned about displaying, EuiEmptyPrompt is the primary component - Remove need for mount() by dive()ing into EuiEmptyPrompt (this also removes the need to specify a[data-test-subj] instead of just [data-test-subj]) - Simplify empty button test - previous test has already checked for href/telemetry - Cover uncovered actionPath branch line * Minor Overview cleanup - Remove unused telemetry type - Remove unused CSS class - finally - Remove unused license context from tests * Feedback: UI fixes - Fix setup guide CSS class casing - Remove border transparent (UX > UI) * Fix Workplace Search not being hidden on feature control - Whoops, totally missed this 🤦 * Add very basic functional Workplace Search test - Has to be without_host_configured, since with host requires Enterprise Search - Just checks for basic Setup Guide redirect for now - TODO: Add more in-depth feature/privilege functional tests for both plugins at later date * Pay down test render/loading tech debt - Turns out you don't need render(), shallow() skips useEffect already 🤦 - Fix outdated comment import example * DRY out repeated mountWithApiMock into mountWithAsyncContext + Minor engines_overview test refactors: - Prefer to define `const wrapper` at the start of each test rather than a `let wrapper` - this better for sandboxing / not leaking state between tests - Move Platinum license tests above pagination, so the contrast between the two tests are easier to grok * Design feedback - README copy tweak + linting - Remove unused euiCard classes from onboarding card Co-authored-by: Constance Chen <constance.chen.3@gmail.com>

kibanamachine · 2020-07-13T20:44:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 334adbd

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
enterpriseSearch	62	+21	41

History

💚 Build #60946 succeeded 334adbd
💚 Build #60658 succeeded a74825e
💚 Build #60655 succeeded cdcff72
💛 Build #60650 was flaky 7ba1184
💚 Build #60644 succeeded 4bd9745

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger

* Add Workplace Search plugin to app - Adds telemetry for Workplace Search - Adds routing for telemetry and overview - Registers plugin * Add breadcrumbs for Workplace Search * Add Workplace Search index * Add route paths, types and shared assets * Add shared Workplace Search components * Add setup guide to Workplace Search * Add error state to Workplace Search * Add Workplace Search overview This is the functional MVP for Workplace Search * Update telemetry per recent changes - Remove saved objects indexing - add schema definition - remove no_ws_account - minor cleanup * Fix pluralization syntax - Still not working but fixed the syntax nonetheless * Change pluralization method - Was unable to get the `FormattedMessage` to work using the syntax in the docs. Always added ‘more’, even when there were zero (or one for users). This commit uses an alternative approach that works * Update readme * Fix duplicate i18n label * Fix failing test from previous commit :facepalm: * Update link for image in Setup Guide * Remove need for hash in routes Because of a change in the Workplace Search rails code, we can now use non-hash routes that will be redirected by rails so that we don’t have users stuck on the overview page in Workplace Search when logging in * Directly link to source details from activity feed Previously the dashboard in legacy Workplace Search linked to the sources page and this was replicated in the Kibana MVP. This PR aligns with the legacy dashboard directly linking to the source details https://github.com/elastic/ent-search/pull/1688 * Add warn logging to Workplace Search telemetry collector * Change casing to camel to match App Search * Misc security feedback for Workplace Search * Update licence mocks to match App Search * PR feedback from App Search PR * REmove duplicate code from merge conflict * Fix tests * Move varible declaration inside map for TypeScript There was no other way 🤦 * Refactor last commit * Add punctuation Smallest commit ever. * Fix actionPath type errors * Update rebase feedback * Fix failing test * Update telemetry test after AS PR feedback * DRY out error state prompt copy * DRY out telemetry endpoint into a single route + DRY out DRY out endpoint - Instead of /api/app_search/telemetry & /api/workplace_search/telemetry, just have a single /api/enterprise_search/telemetry endpoint that takes a product param - Update public/send_telemetry accordingly (+ write tests for SendWorkplaceSearchTelemetry) DRY out helpers - Pull out certain reusable helper functions into a shared lib/ folder and have them take the repo id/name as a param - Move tests over - Remove misplaced comment block +BONUS - pull out content type header that's been giving us grief in Chrome into a constant * Remove unused telemetry type * Minor server cleanup - DRY out mockLogger * Setup Guide cleanup * Clean up Loading component - use EUI vars per feedback - remove unnecessary wrapper - adjust vh for Kibana layout - Actually apply loadingSpinner styles * Misc i18n fixes + minor newline reduction, because prettier lets me * Refactor Recent Activity component/styles - Remove table markup/styles - not semantically correct or accessible in this case - replace w flex - Fix link colors not inheriting - Add EuiPanel, error colors looked odd against page background - Fix prop/type definition - CSS cleanup - EUI vars, correct BEM, don't target generic selectors * [Opinionated] Refactor RecentActivity component - Pull out iterated activity items into a child subcomponent - Move constants/strings closer to where they're being used, instead of having to jump around the file - Move IActivityFeed definition to this file, since that's primarily where it's used @scottybollinger - if you're not a fan of this commit no worries, just let me know and we can discuss/roll back as needed * Refactor ViewContentHeader - remove unused CSS - fallback cleanup - refactor tests * Refactor ContentSection - Remove unused CSS classes - Refactor tests to include all props/more specific assertions * Refactor StatisticCard - Prefer using EuiTextColor to spans / custom classes - Prefer using EuiCard's native `href` behavior over using our own wrapping link/--isClickablec class - Note that when we port the link/destination over to React Router, we should instead opt to use React Router history, which will involve creating a EuiCard helper - Make test a bit more specific * Minor OrganizationStats cleanup - Use EuiFlexGrid * Refactor OnboardingSteps - i18n - Compact i18n newlines (nit) - Convert FormattedMessage to i18n.translate for easier test assertions - Org Name CTA - Move to separate child subcomponent to make it easier to quickly skim the parent container - Remove unused CSS class - Fix/add responsive behavior - Tests refactor - Use describe() blocks to break up tests by card/section - Make sure each card has tests for each state - zero, some/complete, and disabled/no access - Assert by plain text now that we're using i18n.translate() - Remove ContentSection/EuiPanel assertions - they're not terribly useful, and we have more specific elements to check - Add accounts={0} test to satisfy yellow branch line * Clean up OnboardingCard - Remove unused CSS class - Remove unnecessary template literal Tests - Swap out check for EuiFlexItem - it's not really the content we're concerned about displaying, EuiEmptyPrompt is the primary component - Remove need for mount() by dive()ing into EuiEmptyPrompt (this also removes the need to specify a[data-test-subj] instead of just [data-test-subj]) - Simplify empty button test - previous test has already checked for href/telemetry - Cover uncovered actionPath branch line * Minor Overview cleanup - Remove unused telemetry type - Remove unused CSS class - finally - Remove unused license context from tests * Feedback: UI fixes - Fix setup guide CSS class casing - Remove border transparent (UX > UI) * Fix Workplace Search not being hidden on feature control - Whoops, totally missed this 🤦 * Add very basic functional Workplace Search test - Has to be without_host_configured, since with host requires Enterprise Search - Just checks for basic Setup Guide redirect for now - TODO: Add more in-depth feature/privilege functional tests for both plugins at later date * Pay down test render/loading tech debt - Turns out you don't need render(), shallow() skips useEffect already 🤦 - Fix outdated comment import example * DRY out repeated mountWithApiMock into mountWithAsyncContext + Minor engines_overview test refactors: - Prefer to define `const wrapper` at the start of each test rather than a `let wrapper` - this better for sandboxing / not leaking state between tests - Move Platinum license tests above pagination, so the contrast between the two tests are easier to grok * Design feedback - README copy tweak + linting - Remove unused euiCard classes from onboarding card Co-authored-by: Constance Chen <constance.chen.3@gmail.com> Co-authored-by: Constance Chen <constance.chen.3@gmail.com>

scottybollinger added release_note:enhancement Feature:Plugins v7.9.0 labels Jul 7, 2020

scottybollinger changed the title ~~Scottybollinger/feature/workplace search mvp~~ Workplace Search in Kibana MVP Jul 7, 2020

scottybollinger requested a review from cee-chen July 7, 2020 16:12

scottybollinger force-pushed the scottybollinger/feature/workplace-search-mvp branch 3 times, most recently from 8222835 to e5180fa Compare July 8, 2020 17:59

scottybollinger and others added 17 commits July 9, 2020 13:49

Add Workplace Search plugin to app

5f302b6

- Adds telemetry for Workplace Search - Adds routing for telemetry and overview - Registers plugin

Add breadcrumbs for Workplace Search

3a910a0

Add Workplace Search index

c4d6d00

Add route paths, types and shared assets

5b28f24

Add shared Workplace Search components

72c3205

Add setup guide to Workplace Search

ece0ab0

Add error state to Workplace Search

fc4675d

Add Workplace Search overview

793411e

This is the functional MVP for Workplace Search

Update telemetry per recent changes

bfbc771

- Remove saved objects indexing - add schema definition - remove no_ws_account - minor cleanup

Fix pluralization syntax

fead028

- Still not working but fixed the syntax nonetheless

Change pluralization method

4fe63cc

- Was unable to get the `FormattedMessage` to work using the syntax in the docs. Always added ‘more’, even when there were zero (or one for users). This commit uses an alternative approach that works

Update readme

78c28a3

Fix duplicate i18n label

123dcd2

Fix failing test from previous commit

f96fc6e

🤦

Update link for image in Setup Guide

640102e

Remove need for hash in routes

708bae3

Because of a change in the Workplace Search rails code, we can now use non-hash routes that will be redirected by rails so that we don’t have users stuck on the overview page in Workplace Search when logging in

Directly link to source details from activity feed

5805cd5

Previously the dashboard in legacy Workplace Search linked to the sources page and this was replicated in the Kibana MVP. This PR aligns with the legacy dashboard directly linking to the source details elastic/ent-search#1688

cee-chen added 4 commits July 10, 2020 16:30

Refactor ViewContentHeader

785dd98

- remove unused CSS - fallback cleanup - refactor tests

Refactor ContentSection

7a00bfe

- Remove unused CSS classes - Refactor tests to include all props/more specific assertions

cee-chen reviewed Jul 11, 2020

View reviewed changes

Minor OrganizationStats cleanup

eb5d40f

- Use EuiFlexGrid

johnbarrierwilson reviewed Jul 11, 2020

View reviewed changes

...erprise_search/public/applications/workplace_search/components/overview/recent_activity.scss Outdated Show resolved Hide resolved

cee-chen added 3 commits July 10, 2020 19:34

Minor Overview cleanup

cdcff72

- Remove unused telemetry type - Remove unused CSS class - finally - Remove unused license context from tests

cee-chen reviewed Jul 11, 2020

View reviewed changes

cee-chen added 5 commits July 10, 2020 20:54

Feedback: UI fixes

dafee0d

- Fix setup guide CSS class casing - Remove border transparent (UX > UI)

Fix Workplace Search not being hidden on feature control

7e72e42

- Whoops, totally missed this 🤦

Add very basic functional Workplace Search test

89759f4

- Has to be without_host_configured, since with host requires Enterprise Search - Just checks for basic Setup Guide redirect for now - TODO: Add more in-depth feature/privilege functional tests for both plugins at later date

Pay down test render/loading tech debt

d2855ff

- Turns out you don't need render(), shallow() skips useEffect already 🤦 - Fix outdated comment import example

johnbarrierwilson approved these changes Jul 13, 2020

View reviewed changes

x-pack/plugins/enterprise_search/README.md Outdated Show resolved Hide resolved

cee-chen added 2 commits July 13, 2020 09:04

Merge remote-tracking branch 'upstream/master' into scottybollinger/f…

9db273b

…eature/workplace-search-mvp

Design feedback

334adbd

- README copy tweak + linting - Remove unused euiCard classes from onboarding card

cee-chen approved these changes Jul 13, 2020

View reviewed changes

scottybollinger merged commit 41c4f18 into elastic:master Jul 13, 2020

scottybollinger deleted the scottybollinger/feature/workplace-search-mvp branch July 13, 2020 18:10

scottybollinger mentioned this pull request Jul 13, 2020

[7.x] Workplace Search in Kibana MVP (#70979) #71513

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Workplace Search in Kibana MVP #70979

Workplace Search in Kibana MVP #70979

scottybollinger commented Jul 7, 2020 •

edited

Loading

cee-chen commented Jul 9, 2020

scottybollinger commented Jul 9, 2020

cee-chen commented Jul 9, 2020

scottybollinger commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

cee-chen left a comment •

edited

Loading

johnbarrierwilson commented Jul 11, 2020

johnbarrierwilson left a comment

cee-chen left a comment

cee-chen Jul 11, 2020

cee-chen Jul 11, 2020

cee-chen commented Jul 11, 2020

cee-chen commented Jul 11, 2020

johnbarrierwilson left a comment

cee-chen left a comment

cee-chen commented Jul 13, 2020

kibanamachine commented Jul 13, 2020

Workplace Search in Kibana MVP #70979

Workplace Search in Kibana MVP #70979

Conversation

scottybollinger commented Jul 7, 2020 • edited Loading

Summary

QA

Checklist

For maintainers

cee-chen commented Jul 9, 2020

scottybollinger commented Jul 9, 2020

cee-chen commented Jul 9, 2020

scottybollinger commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

cee-chen left a comment • edited Loading

Choose a reason for hiding this comment

johnbarrierwilson commented Jul 11, 2020

johnbarrierwilson left a comment

Choose a reason for hiding this comment

cee-chen left a comment

Choose a reason for hiding this comment

cee-chen Jul 11, 2020

Choose a reason for hiding this comment

cee-chen Jul 11, 2020

Choose a reason for hiding this comment

cee-chen commented Jul 11, 2020

cee-chen commented Jul 11, 2020

johnbarrierwilson left a comment

Choose a reason for hiding this comment

cee-chen left a comment

Choose a reason for hiding this comment

cee-chen commented Jul 13, 2020

kibanamachine commented Jul 13, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

History

scottybollinger commented Jul 7, 2020 •

edited

Loading

cee-chen left a comment •

edited

Loading