Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[i18n] integrate new translations + new i18n check #70193" #71039

Closed
wants to merge 1 commit into from

Conversation

mistic
Copy link
Member

@mistic mistic commented Jul 8, 2020

That PR is an attempt to revert #70423

@XavierM reported the mentioned PR broke the translations for security solutions. As the original PR was not backported yet I believe we will be better by just revert it for now.

@Bamieh @afharo could you please verify if it reverts everything as expected?

@mistic mistic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 8, 2020
@mistic mistic requested review from XavierM, afharo and Bamieh July 8, 2020 03:14
@mistic mistic requested a review from a team as a code owner July 8, 2020 03:14
@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps


Test Failures

X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/basic/tests/find_statuses·ts.detection engine api security and spaces enabled find_statuses "after each" hook for "should return a single rule status when a single rule is loaded from a find status with defaults added"

Link to Jenkins

Standard Out

[00:00:00]       │
[00:00:00]         └-: detection engine api security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:02:04]           └-: find_statuses
[00:02:04]             └-> "before all" hook
[00:02:04]             └-> should return an empty find statuses body correctly if no statuses are loaded
[00:02:04]               └-> "before each" hook: global before each
[00:02:04]               └-> "before each" hook
[00:02:04]                 │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] adding index lifecycle policy [.siem-signals-default]
[00:02:04]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:02:04]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1]
[00:02:04]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:02:04]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:02:04]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:02:04]               └- ✓ pass  (12ms) "detection engine api security and spaces enabled find_statuses should return an empty find statuses body correctly if no statuses are loaded"
[00:02:04]             └-> "after each" hook
[00:02:04]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] [.siem-signals-default-000001/-ZAZBmNsRhex5aXOm5GN8Q] deleting index
[00:02:04]               │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] removing template [.siem-signals-default]
[00:02:04]             └-> should return a single rule status when a single rule is loaded from a find status with defaults added
[00:02:04]               └-> "before each" hook: global before each
[00:02:04]               └-> "before each" hook
[00:02:04]                 │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] adding index lifecycle policy [.siem-signals-default]
[00:02:04]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:02:04]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1]
[00:02:04]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:02:05]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:02:05]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:02:09]               └- ✓ pass  (4.3s) "detection engine api security and spaces enabled find_statuses should return a single rule status when a single rule is loaded from a find status with defaults added"
[00:02:09]             └-> "after each" hook
[00:02:09]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] [.siem-signals-default-000001/cEcyE985RMKNvzt8475bZA] deleting index
[00:02:09]               │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1594178141918546867] removing template [.siem-signals-default]
[00:02:09]               └- ✖ fail: "detection engine api security and spaces enabled find_statuses "after each" hook for "should return a single rule status when a single rule is loaded from a find status with defaults added""
[00:02:09]               │

Stack Trace

{ ResponseError: Response Error
    at IncomingMessage.response.on (/dev/shm/workspace/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:287:25)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
  name: 'ResponseError',
  meta:
   { body:
      { took: 8,
        timed_out: false,
        total: 1,
        deleted: 0,
        batches: 1,
        version_conflicts: 1,
        noops: 0,
        retries: [Object],
        throttled_millis: 0,
        requests_per_second: -1,
        throttled_until_millis: 0,
        failures: [Array] },
     statusCode: 409,
     headers:
      { 'content-type': 'application/json; charset=UTF-8',
        'content-length': '649' },
     warnings: null,
     meta:
      { context: null,
        request: [Object],
        name: 'elasticsearch-js',
        connection: [Object],
        attempts: 0,
        aborted: false } } }

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR will break the CI step Internationalization check.

Maybe we can fix the removal of the translations by adding them through the right procedure?

cc/ @elastic/kibana-localization @chiweichang ?

@mistic
Copy link
Member Author

mistic commented Jul 8, 2020

Closing this after our offline conversion about this topic. We'll just wait for the correct translations!

@mistic mistic closed this Jul 8, 2020
@Bamieh
Copy link
Member

Bamieh commented Jul 11, 2020

Thanks for following up while i was on vacation. Yes these missing labels will be reintroduced once we receive the new extracted labels from translators on the next FF. This new check is very important to avoid any runtime UI errors in case we have malformed translation labels.

The most important branch to contain the translations is the 7.8 branch since 7.8.2 will be released soon. The siem labels are there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants