Require granted API Keys to have a name #71623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
release_note:skip
|
Pinging @elastic/kibana-security (Team:Security) |
|
ACK: reviewing... |
azasypkin
approved these changes
Jul 14, 2020
| @@ -697,4 +711,8 @@ export class AlertsClient { | |||
| references, | |||
| }; | |||
| } | |||
|
|
|||
| private generateAPIKeyName(alertTypeId: string, alertName: string) { | |||
| return _.truncate(`Alerting: ${alertTypeId}/${alertName}`, { length: 256 }); | |||
There was a problem hiding this comment.
question: is this 256 limit documented anywhere? Just curious.
There was a problem hiding this comment.
Nope, I found this by testing API keys with very long names. Also tested a bunch of "special" characters, and there doesn't seem to be a restriction on what you're allowed to put here
| @@ -188,7 +189,7 @@ export class APIKeys { | |||
| * Tries to grant an API key for the current user. | |||
| * @param request Request instance. | |||
| */ | |||
| async grantAsInternalUser(request: KibanaRequest) { | |||
| async grantAsInternalUser(request: KibanaRequest, createParams: CreateAPIKeyParams) { | |||
There was a problem hiding this comment.
optional nit: missing JSDoc for createParams (I admit these JSDocs are useless most of the time, so feel free to ignore to not wait for CI run once again).
There was a problem hiding this comment.
I am going to merge w/o the JSDoc comment, just in the interest of time given our tight schedule today. I'll try to be more diligent about this going forward though!
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Jul 14, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 14, 2020
* master: (21 commits) [Maps] 7.9 design improvements (elastic#71563) [ML] Changing all calls to ML endpoints to use internal user (elastic#70487) [eventLog] prevent log writing when initialization fails (elastic#71339) [Observability] landing page always being displayed (elastic#71494) [IM] Address data stream copy feedback (elastic#71615) [Logs UI] Anomalies page dataset filtering (elastic#71110) [data.search.aggs] Remove `use_field_mapping` from top hits agg (elastic#71168) [ML] Anomaly swim lane embeddable navigation and filter actions (elastic#71082) Fixes typo in siem_cloudtrail job description (elastic#71569) Require granted API Keys to have a name (elastic#71623) Update getUsageForCollection (elastic#71609) Only fetch saved elements once (elastic#71310) [SecuritySolution][Resolver] Adding siem index and guarding process ancestry (elastic#71570) [APM] Additional data telemetry changes (elastic#71112) [Visualize] Fix export table for table export links (elastic#71249) [Search] Server side search API (elastic#70446) use inclusive language (elastic#71607) [Security Solution] Hide timeline footer when Resolver is open (elastic#71516) [Index template wizard] Remove shadow and use border for components panels (elastic#71606) [ML] Kibana API endpoint for histogram chart data (elastic#70976) ...
legrego
added a commit
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #71620