Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][Timeline] Updates all events text timeline #71701

Merged
merged 3 commits into from
Jul 14, 2020
Merged

[SIEM][Timeline] Updates all events text timeline #71701

merged 3 commits into from
Jul 14, 2020

Conversation

MadameSheema
Copy link
Member

Summary

Following @MikePaquette suggestion the default text "All events" has been modified to "All".

Suggestion

image (12)

Final Result

Screenshot 2020-07-14 at 19 03 37

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 14, 2020
@MadameSheema MadameSheema requested review from a team as code owners July 14, 2020 17:04
@MadameSheema MadameSheema self-assigned this Jul 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

patrykkopycinski
patrykkopycinski approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

stephmilovic
stephmilovic approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit b48162b into elastic:master Jul 14, 2020
@MadameSheema MadameSheema deleted the updates-all-events-text-timeline branch July 14, 2020 19:29
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Jul 14, 2020
@MadameSheema
[SIEM][Timeline] Updates all events text timeline (elastic#71701)
a7fe94c 
* updates 'All events' timeline text to 'All'

* updates jest test

* fixes test issue
@MadameSheema MadameSheema mentioned this pull request Jul 14, 2020
Merged
MadameSheema added a commit that referenced this pull request Jul 14, 2020
@MadameSheema
[SIEM][Timeline] Updates all events text timeline (#71701) (#71734)
a5615f5 
* updates 'All events' timeline text to 'All'

* updates jest test

* fixes test issue
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@XavierM XavierM Awaiting requested review from XavierM

@andrew-goldstein andrew-goldstein Awaiting requested review from andrew-goldstein

@angorayc angorayc Awaiting requested review from angorayc

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MadameSheema @elasticmachine @kibanamachine @patrykkopycinski @stephmilovic @MindyRS