Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Fix clear filters on agents table not working #71978

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

Fixes #69793. This PR fixes the "Clear filters" link in agents table not working when a status and/or agent config filter has been applied. It also adjusts the condition of when to display "no agents" prompt so that it does not flash erroneously when agents data is being fetched.

@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience release_note:fix v8.0.0 v7.10.0 v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 15, 2020
@jen-huang jen-huang requested a review from a team July 15, 2020 23:02
@jen-huang jen-huang self-assigned this Jul 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet
Copy link
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ingestManager 1.1MB +201.0B 1.1MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang
Copy link
Contributor Author

@nchaulet Thanks for the upstream merge! 🙏🏻

@jen-huang jen-huang merged commit 9195ce4 into elastic:master Jul 16, 2020
@jen-huang jen-huang deleted the ingest/fix/fleet-clear-filter branch July 16, 2020 17:36
jen-huang added a commit to jen-huang/kibana that referenced this pull request Jul 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jen-huang added a commit that referenced this pull request Jul 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jen-huang added a commit that referenced this pull request Jul 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest Manager]: Clicking 'Clear Filters' does not clear the selected filters on Ingest Manager 'Fleet' tab
4 participants