Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] In-progress PR comments #72211

Merged
merged 20 commits into from
Jul 21, 2020

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Jul 17, 2020

Closes #71454

Immediately post PR comments (with an in-progress indicator) upon failed steps, so that people are pinged as soon as it's known that their PR will fail. Finalize the comment at the end as usual.

In-progress:

Screen Shot 2020-07-16 at 8 56 13 PM

Final:

Screen Shot 2020-07-16 at 8 56 54 PM

@brianseeders brianseeders added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.9.0 v7.8.1 v7.7.2 v6.8.12 Team:Operations Team label for Operations Team labels Jul 17, 2020
@brianseeders
Copy link
Contributor Author

/merge upstream

@brianseeders brianseeders requested a review from a team July 20, 2020 20:15
@brianseeders brianseeders marked this pull request as ready for review July 20, 2020 20:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, great work making this straightforward. LGTM!

vars/githubPr.groovy Outdated Show resolved Hide resolved
@brianseeders
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders merged commit 2437db6 into elastic:master Jul 21, 2020
@brianseeders brianseeders deleted the in-progress-pr-comments branch July 21, 2020 20:52
brianseeders added a commit to brianseeders/kibana that referenced this pull request Jul 21, 2020
brianseeders added a commit to brianseeders/kibana that referenced this pull request Jul 21, 2020
brianseeders added a commit to brianseeders/kibana that referenced this pull request Jul 21, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 22, 2020
* master: (23 commits)
  Stabilize closing toast (elastic#72097)
  stabilize failing test (elastic#72086)
  Stabilize filter bar test (elastic#72032)
  Unskip vislib tests (elastic#71452)
  [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689)
  fix preAuth/preRouting mocks (elastic#72663)
  [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788)
  [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584)
  [Security Solution] Fixes exception modal not loading content (elastic#72770)
  [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748)
  [Detections] Add validation for Threshold value field (elastic#72611)
  [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730)
  [Security Solution][Detections] Validate file type of value lists (elastic#72746)
  [pre-req] New Component Layout proposal (elastic#72385)
  [ML] do not throw an error when agg is not supported by UI (elastic#72685)
  [Resolver] Origin process (elastic#72382)
  [Ingest Manager] Allow to force unenroll from the UI (elastic#72386)
  skip 6.8 branch when triggering baseline-capture builds (elastic#72706)
  [CI] In-progress PR comments (elastic#72211)
  Fix sorting of scripted string fields (elastic#72681)
  ...
brianseeders added a commit to brianseeders/kibana that referenced this pull request Aug 1, 2020
# Conflicts:
#	vars/githubPr.groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v6.8.12 v7.8.1 v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] In-progress PR notifications
4 participants