Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.9] [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (#71990) #72213

Merged
merged 2 commits into from
Jul 17, 2020
Merged

[7.9] [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (#71990) #72213

merged 2 commits into from
Jul 17, 2020

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Jul 17, 2020

Backports the following commits to 7.9:

@rylnd @elasticmachine
[Security Solution][Detections,Lists] Miscellaneous post-FF fixes (el…
2e25979 
…astic#71990)

* Overview Alerts Histogram stacking defaults to signal.rule.name

Since this is now the default for all AlertsHistograms, I've moved this
default upstream into the histogram itself.

* Replace magic strings with our constant ENDPOINT_LIST_ID

Also replaced a few unintentional uses of this string with the
non-reserved 'endpoint_list_id'.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rylnd rylnd added the backport label Jul 17, 2020
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / persist the deletion of a column.persistent timeline persist the deletion of a column

Link to Jenkins

Stack Trace

AssertionError: expected 'message' to not equal 'message'
    at Context.<anonymous> (http://elastic:changeme@localhost:61141/__cypress/tests?p=cypress/integration/timeline_local_storage.spec.ts-637:686:40)

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit afceb3a into elastic:7.9 Jul 17, 2020
@rylnd rylnd deleted the backport/7.9/pr-71990 branch July 17, 2020 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rylnd @kibanamachine