Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nav] show if chrome.isVisible() #7309

Merged
merged 1 commit into from
Jun 9, 2016
Merged

[nav] show if chrome.isVisible() #7309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ui/public/kbn_top_nav/kbn_top_nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module.directive('kbnTopNav', function (Private) {
// It will no accept any programatic way of setting its name
// besides this because it happens so early in the digest cycle
return `
<navbar class="kibana-nav-options">
<navbar ng-show="chrome.getVisible()" class="kibana-nav-options">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should this use ng-if instead of ng-show? I don't think the embed view needs the DOM element at all, does it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally yes, but if we ng-if then the timepicker isn't instantiated and we won't get things like auto refresh.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Thanks!

<div ng-transclude></div>
<div class="button-group kibana-nav-actions" role="toolbar">
<button
Expand Down