Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.9] changes for upgrade assistant functional test to incorporate test user (#70071) #73145

Merged
merged 6 commits into from
Aug 4, 2020
Merged

[7.9] changes for upgrade assistant functional test to incorporate test user (#70071) #73145

merged 6 commits into from
Aug 4, 2020

Conversation

rashmivkulkarni
Copy link
Contributor

Backports the following commits to 7.9:

@rashmivkulkarni @elasticmachine
changes for upgrade assistant functional test to incorporate test user (
2a18b5b 
elastic#70071)

* changes for upgrade assistant functional test to incorporate test user

* changes to toggle on/off

* upgrade_assistant role

* upgrade assistant

* more debug statements to check on cloud

* commented the sleeps to check toggle button

* reduced the sleep to 2 seconds to test on cloud

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@legrego/ @jportner - can u help me please figure out what changed btw master and 7.9 - same role is passing on master - ref PR (#70071)

@rashmivkulkarni
Copy link
Contributor Author

when ran locally logs say ERROR browser[SEVERE] http://localhost:5620/api/upgrade_assistant/status - Failed to load resource: the server responded with a status of 403 (Forbidden) │ debg expectDeprecationLoggingLabel()
Screenshot captured:
Screen Shot 2020-07-31 at 8 46 12 AM

@rashmivkulkarni @jportner
Update x-pack/test/functional/config.js
35fcd7f 
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@alisonelizabeth

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth
alisonelizabeth approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM

@rashmivkulkarni rashmivkulkarni merged commit e404b19 into elastic:7.9 Aug 4, 2020
@alisonelizabeth alisonelizabeth mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner left review comments

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rashmivkulkarni @kibanamachine @alisonelizabeth @jportner @elasticmachine