Move config setting for By Value Embeddables to Dashboard #73870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dashboard plugin
ThomThomson
added
Feature:Dashboard
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 30, 2020
…tic#73870 to show the option
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 30, 2020
…tic#73870 to show the option
4 tasks
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
approved these changes
Jul 31, 2020
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 31, 2020
…to dashboard plugin (elastic#73870)
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 31, 2020
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the configuration item which determines whether or not to show the new flow for lens / visualize embeddable creation onto the dashboard start contract.
This way, all by value PRs, including #70272, #72256, and the upcoming PRs for the
add to library, andunlink from libraryactions can refer to the same configuration setting.Note
This config setting is temporary, and used to hide all 'by value' changes. Once all blockers to the 'by value' system are resolved (#61663, #67931, #71499), this config setting can be removed.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers