Disable in-chart "Explore underlying data" by default

[streamich]

Summary

This change swaps the default value of xpack.discoverEnhanced.actions.exploreDataInChart.enabled setting in kibana.yml from true to false, to make in-chart "Explore underlying data" action introduced in 7.9 disabled by default.

We would like to change the setting because product team decided that it is better to have this functionality as opt-it.

P.S. It is not a breaking change and it does not affect drilldowns.

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[timroes]

This PR description is missing some details. Why should it be switched? What's the reasoning why we decided to toggle it? Also, if this flag is disabled, will that potentially break already configured drilldowns on that action if a user now suddenly has it disabled and if so in what way will they exacatly break? Because if it does this is a breaking change, and we need to be sure it will be communicated like that in the release notes.

[Dosant]

I also missed the communication where was decided we want to turn it off,
if so, should the code backing it be removed completely? a bit less stuff to maintain and doubt that someone would use this feature with opt-in approach?

[alexh97]

There seems to be some pushback from product on this feature. I will be following up to better understand the "why". Let's hold off on merging this until we have the answers.

[AlonaNadler]

Currently in 7.9 BC when in the dashboard on read mode. When you click on a chart this popup appear for all panels with every click/interaction

In addition, it also appears in the action panel (which is the right place to have it)

The plan was to have explore underlining data only in the action panel (like in the second image).
interacting with chart to filter should still be the default. I'm concerned that adding the option to explore underlying data in every interaction is disturbing

[alexh97]

After a conversation with @AlonaNadler I agree that we should disable this feature by default. This has potential of becoming very intrusive to data analysis workflow that visualization users are used to. We should move forward with this PR and then consider adding this setting to the Advanced Settings page.

[streamich]

...consider adding this setting to the Advanced Settings page.

@alexh97 I'm thinking maybe we should have a per dashboard settings also and move it there.

@timroes We want to switch from opt-out to opt-in, because product decided so, no other reason. It is a new functionality released in 7.9, this flag does not affect how drilldowns work and will not break them.

...should the code backing it be removed completely?

@Dosant We are actually considering making this action more discoverable, like see @alexh97 comment above, we could move the setting into Advanced Settings.

[streamich]

@elasticmachine merge upstream

[Dosant]

Code changes LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 9104ce2

Build metrics

✅ unchanged

History

• 💚 Build #66600 succeeded 37983f5
• 💔 Build #66560 failed 5d9739f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kertal]

Code LGTM, tested locally in Chrome, MacOs "Explore underlying data" in disabled by default