Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Adds rule override Cypress tests #74367

Merged
merged 2 commits into from
Aug 5, 2020
Merged

[SIEM] Adds rule override Cypress tests #74367

merged 2 commits into from
Aug 5, 2020

Conversation

MadameSheema
Copy link
Member

Summary

Adds a new Cypress test in order to check that a rule with all the override options selected can be properly created.

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Aug 5, 2020
@MadameSheema MadameSheema requested review from a team as code owners August 5, 2020 13:49
@MadameSheema MadameSheema self-assigned this Aug 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

FrankHassanabad
FrankHassanabad approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +89.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit 549c256 into elastic:master Aug 5, 2020
@MadameSheema MadameSheema deleted the rule-override branch August 5, 2020 15:45
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Aug 6, 2020
@MadameSheema
[SIEM] Adds rule override Cypress tests (elastic#74367)
0c5ed83 
* implements rule override test

* refactors the code
@MadameSheema MadameSheema mentioned this pull request Aug 6, 2020
Merged
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Aug 6, 2020
@MadameSheema
[SIEM] Adds rule override Cypress tests (elastic#74367)
80862b9 
* implements rule override test

* refactors the code
@MadameSheema MadameSheema mentioned this pull request Aug 6, 2020
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 7, 2020
MadameSheema added a commit that referenced this pull request Aug 10, 2020
@MadameSheema @elasticmachine
[SIEM] Adds rule override Cypress tests (#74367) (#74535)
9ac2084 
* implements rule override test

* refactors the code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MadameSheema added a commit that referenced this pull request Aug 10, 2020
@MadameSheema @elasticmachine
[SIEM] Adds rule override Cypress tests (#74367) (#74534)
b5ddd65 
* implements rule override test

* refactors the code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 10, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@peluja1012 peluja1012 Awaiting requested review from peluja1012

@rylnd rylnd Awaiting requested review from rylnd

@dhurley14 dhurley14 Awaiting requested review from dhurley14

@spong spong Awaiting requested review from spong

@yctercero yctercero Awaiting requested review from yctercero

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @kibanamachine @FrankHassanabad @MindyRS