Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Update the browser/document title on plugin navigation #74392

Merged
merged 6 commits into from
Aug 10, 2020
Merged

[Enterprise Search] Update the browser/document title on plugin navigation #74392

merged 6 commits into from
Aug 10, 2020

Commits on Aug 10, 2020

  1. Rename kibana_breadcrumbs to kibana_chrome 

    - in anticipation of upcoming refactor where SetPageChrome now handles document title as well as Kibana breadcrumbs
+ cleanup exports
    @cee-chen
    cee-chen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    3d92c64 View commit details
    Browse the repository at this point in the history

  2. Add generate_title helpers 

    - will be used by new set_chrome helper
    @cee-chen
    cee-chen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    d2ed181 View commit details
    Browse the repository at this point in the history

  3. Add setDocTitle context + behavior to set_chrome 

    + refactor set_chrome.test.tsx:
  - add title tests
  - add SetWorkplaceSearchChrome test to increase coverage
  - clean up inner/outer call in favor of simpler mocks/imports
  - simplify isRoot tests
    @cee-chen
    cee-chen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    ed93556 View commit details
    Browse the repository at this point in the history

  4. Update plugins to set product titles 

    - on mount but before render
    @cee-chen
    cee-chen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    ac26757 View commit details
    Browse the repository at this point in the history

  5. Copy feedback - change pipe separator to hyphen 

    - to match ' - Elastic'
    @cee-chen
    cee-chen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    5d75916 View commit details
    Browse the repository at this point in the history

  6. Add functional tests confirming that document titles updated

    @cee-chen
    cee-chen committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    2b7bba5 View commit details
    Browse the repository at this point in the history