Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Critical: Filter out non-Detections jobs in Detections telemetry #74456

Merged
merged 1 commit into from
Aug 5, 2020
Merged

[Security Solution][Detections] Critical: Filter out non-Detections jobs in Detections telemetry #74456

merged 1 commit into from
Aug 5, 2020

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Aug 5, 2020

Summary

Our jobs summary call returns all installed jobs regardless of group; passing groups as jobIds does not perform group filtering. As a result, we were counting all installed ML jobs, not just those in the security group.

This adds a helper predicate on which to filter these results, and updates tests accordingly.

Checklist

For maintainers

@rylnd
Filter out non-security jobs when collecting Detections telemetry
f86e279 
Our jobs summary call returns all installed jobs regardless of group;
passing groups as jobIds does not perform group filtering.

This adds a helper predicate function on which to filter these results,
and updates tests accordingly.
@rylnd rylnd added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 5, 2020
@rylnd rylnd requested a review from spong August 5, 2020 22:04
@rylnd rylnd self-assigned this Aug 5, 2020
@rylnd rylnd added bug Fixes for quality problems that affect the customer experience v7.10.0 v7.9.0 labels Aug 5, 2020
@rylnd rylnd changed the title Filter out non-security jobs when collecting Detections telemetry [Security Solution][Detections] Critical: Filter out non-Detections jobs in Detections telemetry Aug 5, 2020
@rylnd rylnd marked this pull request as ready for review August 5, 2020 22:39
@rylnd rylnd requested review from a team as code owners August 5, 2020 22:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

spong
spong approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired with @rylnd to review changes and verified fix resulted in the correct telemetry being submitted. Nice catching this Ryland! Thanks for clean fix and tests -- LGTM!

@rylnd rylnd mentioned this pull request Aug 5, 2020
Closed
7 tasks
@rylnd rylnd merged commit f5c9aa8 into elastic:master Aug 5, 2020
@rylnd rylnd deleted the fix_jobs_telemtry branch August 5, 2020 23:55
@rylnd rylnd mentioned this pull request Aug 5, 2020
Merged
rylnd added a commit to rylnd/kibana that referenced this pull request Aug 5, 2020
@rylnd
Filter out non-security jobs when collecting Detections telemetry (el…
f8c3614 
…astic#74456)

Our jobs summary call returns all installed jobs regardless of group;
passing groups as jobIds does not perform group filtering.

This adds a helper predicate function on which to filter these results,
and updates tests accordingly.
@rylnd rylnd mentioned this pull request Aug 5, 2020
Merged
rylnd added a commit to rylnd/kibana that referenced this pull request Aug 5, 2020
@rylnd
Filter out non-security jobs when collecting Detections telemetry (el…
9d90716 
…astic#74456)

Our jobs summary call returns all installed jobs regardless of group;
passing groups as jobIds does not perform group filtering.

This adds a helper predicate function on which to filter these results,
and updates tests accordingly.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
securitySolution 804.7KB +107.0B 804.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rylnd added a commit that referenced this pull request Aug 6, 2020
@rylnd
Filter out non-security jobs when collecting Detections telemetry (#7…
75650cd 
…4456) (#74466)

Our jobs summary call returns all installed jobs regardless of group;
passing groups as jobIds does not perform group filtering.

This adds a helper predicate function on which to filter these results,
and updates tests accordingly.
rylnd added a commit that referenced this pull request Aug 6, 2020
@rylnd
Filter out non-security jobs when collecting Detections telemetry (#7…
c6c1eb4 
…4456) (#74467)

Our jobs summary call returns all installed jobs regardless of group;
passing groups as jobIds does not perform group filtering.

This adds a helper predicate function on which to filter these results,
and updates tests accordingly.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 6, 2020
@gmmorris
Merge branch 'master' into alerting/log-alert-task-reschedule
924d9f8 
* master: (208 commits)
  Observability Overview fix extra basepath prepend for alerting fetch (elastic#74465)
  [Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (elastic#70010)
  Skip "space with index pattern management disabled" functional test for cloud env (elastic#74073)
  Filter out non-security jobs when collecting Detections telemetry (elastic#74456)
  [Security Solution][Test] Enzyme test for related events button (elastic#74411)
  [SECURITY_SOLUTION] add z-index to get over nav bar (elastic#74427)
  Rename package configs SO to package policies (elastic#74422)
  [DOCS] Add Kibana alerts to Stack Monitoring (elastic#73762)
  skip flaky suite (elastic#71390)
  [ML] DF Analytics: adds functional tests for edit form (elastic#73885)
  Rename agent configs SO to agent policies (elastic#74397)
  [Jenkins] run CI when plugin readmes change (elastic#74388)
  [Metrics UI] Fix validating Metrics Explorer URL (elastic#74311)
  fixing encoding issue with \ for enroll command (elastic#74379)
  [Ingest Manager] Update package registry for testing to f6b01d (elastic#74341)
  Change experimental message for visualizations (elastic#74354)
  [Alerting] Reload the Alerts List when alerts are deleted (elastic#73715)
  [Enterprise Search] Fix/DRY out plugin i18n strings (elastic#74323)
  update empty prompt in analytics list (elastic#74174)
  [Task Manager] Correctly handle `running` tasks when calling RunNow and reduce flakiness in related tests (elastic#73244)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@pjhampton pjhampton mentioned this pull request Nov 18, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@rylnd rylnd

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rylnd @elasticmachine @kibanamachine @spong @MindyRS