Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timelion deprecation doc #74508

Merged
merged 9 commits into from
Aug 11, 2020
Merged

Timelion deprecation doc #74508

merged 9 commits into from
Aug 11, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 6, 2020 •
edited
Loading

Summary

As we want to deprecate Timelion app on 8.0 #63012, we will add a deprecation message with a link to the Docs for the users to guide them on the process they need to follow in order to migrate their existing Timelion timesheets to visualizations and dashboards.

This PR covers the guide. I added a new section on Visualize Timelion App Deprecation, with the steps a user should follow.
Our goals here are:

  • Make the users understand that we aren't deprecating the Timelion visualizations but the Timelion app.
  • Guide the users through the process in order to not lose their sheets.

Checklist

Delete any items that are not applicable to this PR.

@stratoula stratoula marked this pull request as ready for review August 6, 2020 12:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@stratoula stratoula requested a review from a team August 6, 2020 13:09
@stratoula
Copy link
Contributor Author

@gchaps and @KOTungseth your input here will be truly appreciated 😄

@stratoula stratoula changed the title Timelion deprecation docs Timelion deprecation doc Aug 6, 2020
KOTungseth
KOTungseth approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments and suggestions, but overall, this looks great! Thank you for creating this PR!

docs/user/visualize.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion-deprecation.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion-deprecation.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion-deprecation.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion-deprecation.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion-deprecation.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion-deprecation.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion-deprecation.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion-deprecation.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion-deprecation.asciidoc Outdated Show resolved Hide resolved
@stratoula stratoula requested a review from timroes August 10, 2020 06:42
@timroes
Copy link
Contributor

timroes commented Aug 11, 2020

@elasticmachine run docs build

@stratoula
Copy link
Contributor Author

@elasticmachine, run elasticsearch-ci/docs

@stratoula
Copy link
Contributor Author

Preview here https://kibana_74508.docs-preview.app.elstc.co/guide/en/kibana/master/timelion.html#timelion-deprecation

timroes
timroes approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of minor typos or grammar corrections. Fine from my side. Feel free to have someone from the docs team giving this a last look again.

docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
@stratoula
Copy link
Contributor Author

@KOTungseth can you please check it again as we changed it a bit 🙏

gchaps
gchaps reviewed Aug 11, 2020
View reviewed changes
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
gchaps
gchaps approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Otherwise, LGTM

docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
docs/visualize/timelion.asciidoc Outdated Show resolved Hide resolved
@stratoula stratoula merged commit 7b5df7c into elastic:master Aug 11, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Aug 11, 2020
@stratoula
Timelion deprecation doc (elastic#74508)
7473182 
* timelion deprecation doc wip

* Create Timelion Deprecation section to Visualize

* Code review changes

* minor changes

* Make some changes in order to give priotization on how to replace an existing timelion worksheet to a dashboard

* Syntax related improvements

* Final touch

* Remove extra lines and some minor changes
@stratoula stratoula mentioned this pull request Aug 11, 2020
Merged
stratoula added a commit that referenced this pull request Aug 12, 2020
@stratoula
Timelion deprecation doc (#74508) (#74786)
3e0119e 
* timelion deprecation doc wip

* Create Timelion Deprecation section to Visualize

* Code review changes

* minor changes

* Make some changes in order to give priotization on how to replace an existing timelion worksheet to a dashboard

* Syntax related improvements

* Final touch

* Remove extra lines and some minor changes
@stratoula stratoula mentioned this pull request Aug 12, 2020
Merged
3 tasks
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 12, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-pipeli…
bbbe9d2 
…nes/processor-forms-a-d

* 'master' of github.com:elastic/kibana: (25 commits)
  [ML] Removing full lodash library imports (elastic#74742)
  [Search] Server strategy example (elastic#71679)
  [Reporting] Fix and test for Listing of Reports (elastic#74453)
  [maps] fix drawing shapes (elastic#74689)
  [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601)
  Deprecate schema-less specs in Vega (elastic#73805)
  [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287)
  Timelion deprecation doc (elastic#74508)
  [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736)
  [Lens] Add styling options for x and y axes on the settings popover (elastic#71829)
  [Maps] add initial location option that fits to data bounds (elastic#74583)
  theme function (elastic#73451)
  [data.ui.query] Write filters to query log from default editor. (elastic#74474)
  [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607)
  [Canvas][tech-debt] Convert renderers (elastic#74134)
  [security solutions][lists] Adds end to end tests (elastic#74473)
  pluralized for occurrences vs occurrence (elastic#74564)
  Update links that pointed to CONTRIBUTING.md (elastic#74757)
  [Ingest pipelines] Implement tabs in processor flyout (elastic#74469)
  [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/field_components/text_editor.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/append.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/bytes.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/circle.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/field_name_field.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/ignore_missing_field.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/convert.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/csv.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date_index_name.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dot_expander.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/drop.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/index.ts
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/shared.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 12, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
d500411 
* master:
  [Vega] add functional tests for Vega visualization (elastic#74097)
  [ML] Removing full lodash library imports (elastic#74742)
  [Search] Server strategy example (elastic#71679)
  [Reporting] Fix and test for Listing of Reports (elastic#74453)
  [maps] fix drawing shapes (elastic#74689)
  [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601)
  Deprecate schema-less specs in Vega (elastic#73805)
  [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287)
  Timelion deprecation doc (elastic#74508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@gchaps gchaps gchaps approved these changes

@KOTungseth KOTungseth KOTungseth approved these changes

Assignees
No one assigned
Labels
Feature:Timelion Timelion app and visualization release_note:deprecation Team:Docs v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stratoula @elasticmachine @timroes @gchaps @KOTungseth