Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Dashboard First] Decouple Attribute Service and By Value Embeddables (#74302) #74895

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

ThomThomson
Copy link
Contributor

Backports the following commits to 7.x:

…elastic#74302)

* Added an interface that determines if an embeddable can be treated as either by reference or by value
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
dashboard 174 +1 173
embeddable 72 +1 71
total +2

page load bundle size

id value diff baseline
dashboard 687.7KB +8.3KB 679.4KB
embeddable 358.8KB -1.5KB 360.3KB
total +6.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 3d38bab into elastic:7.x Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants