[Metrics UI] Get custom metrics working in inventory alerts with limited UI #75073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
simianhacker
requested changes
Aug 17, 2020
There was a problem hiding this comment.
Everything works as expected. Can you add some tests? I would like to see some stuff around the changes to the following files:
public/alerting/inventory/components/expression.tsxserver/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts
|
@simianhacker I started trying to add tests for the inventory executor when I pushed this PR but ended up running into a lot of issues with mocking the Snapshot API. Would it be okay if we deferred adding tests to this executor until after we've switched over to the Metrics API? That's probably easier to mock |
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
simianhacker
approved these changes
Aug 20, 2020
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Aug 20, 2020
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 21, 2020
Zacqary
added
release_note:enhancement
and removed
release_note:skip
|
Switching release note to enhancement since the full custom metrics UI isn't making it into 7.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #65761
This PR:
In order to create an alert with a custom metric, you need to first add the custom metric using the toolbar on the Inventory page in order to make it available in the alert flyout. There is no UI to create custom metrics from the alert flyout itself, and it will only use the Inventory page's
WaffleOptionsStateas a source of truth for its list of custom metrics. Therefore, this PR does not enable you to create custom metric alerts on the Alert Management page. You can, however, edit alerts that were previously created with custom metrics.I think this is a good incremental push, but to fully close this issue we need to figure out what the UI should look like in order to define custom metrics in the alert flyout.
Tagged with
release_note:skipbecause I think we should generate a release note from the final UI implementation.Checklist