Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): add elastic prefix to eslint-config-kibana #76059

Merged
merged 4 commits into from
Aug 31, 2020
Merged

chore(NA): add elastic prefix to eslint-config-kibana #76059

merged 4 commits into from
Aug 31, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 27, 2020

That PR adds consistency to packages naming by adding an elastic prefix to eslint-config-kibana package.

@mistic mistic requested a review from a team as a code owner August 27, 2020 01:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

spalger
spalger suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed a reference in packages/kbn-plugin-generator/template/.eslintrc.js.ejs

spalger
spalger approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'm wrong, that reference is to the @elastic/* package name

@mistic mistic added the release_note:skip Skip the PR/issue when compiling release notes label Aug 27, 2020
@mistic
Copy link
Member Author

mistic commented Aug 27, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Aug 31, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic added v7.9.2 and removed v7.9.1 labels Aug 31, 2020
@mistic mistic merged commit 0068c87 into elastic:master Aug 31, 2020
@mistic
Copy link
Member Author

mistic commented Aug 31, 2020 •
edited
Loading

7.x: b6821d0
7.9: 5d8081e

@mistic mistic mentioned this pull request Aug 31, 2020
Merged
mistic added a commit to mistic/kibana that referenced this pull request Aug 31, 2020
@mistic @elasticmachine
chore(NA): add elastic prefix to eslint-config-kibana (elastic#76059)
1e0058b 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic added a commit to mistic/kibana that referenced this pull request Aug 31, 2020
@mistic
chore(NA): add elastic prefix to eslint-config-kibana (elastic#76059)
9c3d349 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	packages/elastic-eslint-config-kibana/package.json
@mistic mistic mentioned this pull request Aug 31, 2020
Merged
mistic added a commit that referenced this pull request Sep 1, 2020
@mistic @elasticmachine
chore(NA): add elastic prefix to eslint-config-kibana (#76059) (#76317)
b6821d0 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic added a commit that referenced this pull request Sep 1, 2020
@mistic
chore(NA): add elastic prefix to eslint-config-kibana (#76059) (#76318)
5d8081e 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	packages/elastic-eslint-config-kibana/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.9.2 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibanamachine @tylersmalley @spalger