Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Filter Default policy details #76112

Merged
merged 4 commits into from
Aug 31, 2020

Conversation

pzl
Copy link
Member

@pzl pzl commented Aug 27, 2020

Summary

Fixes a bug, where, if endpoint policy fails to apply, and rolls back to initial policy, then the policy details response differs from the Administration tab (showing success of the rollback, not failure of the attempted policy).

This change filters out the initial policy.

Bug: (we expect statuses to match)

2020-08-27-122444_scrot

After fix:

2020-08-27-123220_scrot

Terminal recording of policy call from master, then same call from this branch. We want to see status: failure
Terminal Animation

Checklist

Delete any items that are not applicable to this PR.

@pzl pzl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.9.1 labels Aug 27, 2020
@pzl pzl requested review from a team as code owners August 27, 2020 16:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@pzl
Copy link
Member Author

pzl commented Aug 31, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pzl pzl removed the v7.9.1 label Aug 31, 2020
@pzl pzl merged commit 4379ca8 into elastic:master Aug 31, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 76112 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 2, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 76112 or prevent reminders by adding the backport:skip label.

@pzl pzl added the v7.9.2 label Sep 3, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 76112 or prevent reminders by adding the backport:skip label.

pzl added a commit to pzl/kibana that referenced this pull request Sep 4, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 4, 2020
pzl added a commit to pzl/kibana that referenced this pull request Sep 10, 2020
@ghost
Copy link

ghost commented Sep 16, 2020

Hi @kevinlog

We have validated this ticket on "7.9.2 Snapshot" Elastic Staging Cloud Environment and observed that we are not able to fail the configuration status on endpoint to validate the ticket .

Build Details:
Elastic Version : 7.9.2 SNAPSHOT

So could you please share the steps on how to fail the configuration on the endpoint under Administration of security app.

image

thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.9.2 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants