Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove "Are you sure" from data frame analytics models #76215

Merged
merged 3 commits into from
Aug 31, 2020
Merged

[ML] Remove "Are you sure" from data frame analytics models #76215

merged 3 commits into from
Aug 31, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 28, 2020 •
edited
Loading

Summary

Per https://elastic.github.io/eui/#/guidelines/writing, we should avoid using "Are you sure" in our UI messages. This PR cleans up some machine learning model-related occurrences of that text.

Checklist

Screenshots (Before)

Delete single data frame analytic model:

image

Delete multiple data frame analytic models:

image

Screenshots (After)

Delete single:

image

Delete multiple:

image

@lcawl lcawl marked this pull request as ready for review August 31, 2020 14:18
@lcawl lcawl requested a review from a team as a code owner August 31, 2020 14:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Aug 31, 2020
@lcawl
Copy link
Contributor Author

lcawl commented Aug 31, 2020

@elasticmachine merge upstream

walterra
walterra approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.2MB -864.0B 8.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 877600a into elastic:master Aug 31, 2020
@lcawl lcawl deleted the model-text branch August 31, 2020 16:35
@lcawl lcawl mentioned this pull request Aug 31, 2020
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Aug 31, 2020
@lcawl
[ML] Remove "Are you sure" from data frame analytics models (elastic#…
293c761 
…76215)
lcawl added a commit that referenced this pull request Aug 31, 2020
@lcawl
[ML] Remove "Are you sure" from data frame analytics models (#76215) (#…
5a2410a 
…76310)
@lcawl lcawl removed the v7.11.0 label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcawl @elasticmachine @kibanamachine @walterra