Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Enterprise Search] Fix various icons in dark mode (#76430) #76461

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Sep 1, 2020

Backports the following commits to 7.x:

* Update Home catalogue icons to use new 28.0 EUI app icons

* Fix App Search engine icons in dark mode

- Convert to React SVG element in order to be able to inherit correct fill in dark mode
- Fix vertical centering (taking advantage of SVG centering for us)
- Move icons directly to the engines overview component instead of having to reach upwards to a shared assets folder for them

* [Cleanup] Move Setup Guide images

- to be nested within their own component views that use them, instead of having to grab them upwards from a shared assets folder
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
enterpriseSearch 203 -2 205

async chunks size

id value diff baseline
enterpriseSearch 357.8KB -334.0B 358.1KB

page load bundle size

id value diff baseline
enterpriseSearch 19.8KB -2.8KB 22.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 07daf4a into elastic:7.x Sep 2, 2020
@cee-chen cee-chen deleted the backport/7.x/pr-76430 branch September 4, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants