Adding KibanaRequest#uuid #76822
Merged
Adding KibanaRequest#uuid #76822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
added
v8.0.0
v7.10.0
release_note:plugin_api_changes
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
mshustov
approved these changes
Sep 21, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
kobelb
added a commit
that referenced
this pull request
Sep 21, 2020
* Adding KibanaRequest#uuid * Adding tests * Fixing test which was mocking uuid.v4() to get expected IDs * Fixing another mock * Updating docs Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleet has rate-limiting on their enrollment endpoint using a preAuthHandler, which utilizes
KibanaRequest#completed$to know when the request is complete and decrement the counter.This isn't an option for their check-in endpoint, which utilizes long-polling. They'd ideally like to decrement the counter once the HTTP request gets to the point where they're just waiting for a configuration change. This isn't currently possible because they're unable to uniquely identify the requests to ensure that we're only decrementing the counter once per request. Adding the
KibanaRequest#uuidallows this to work as expected kobelb@e5c2f47Dev Docs
The
KibanaRequestnow has auuidproperty which is a UUID that uniquely identifies the request.