Deterministic output for doc types #76890
Conversation
They generate non-deterministic types microsoft/rushstack#1958
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
added
the
release_note:skip
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
| "incremental": false, | ||
| "declaration": true, |
There was a problem hiding this comment.
Just to understand, if it's only impacting types / doc generation, why isn't this single change enough?
There was a problem hiding this comment.
incremental: false here fixed the problem only for types inferred within the project. However, logging.appenders unfolds to @kbn/config-schema type https://github.com/elastic/kibana/pull/76890/files#diff-66a08ea686ee74b5fa19fbb89c8c7803L366 @kbn/config-schema/tsconfig.json has incremental builds enabled. I decided that I'd rather specify an explicit type for this case than disable incremental builds for the @kbn/config-schema package.
There was a problem hiding this comment.
Ok, thanks for the explanation
* disable incremental builds for public type generation. They generate non-deterministic types microsoft/rushstack#1958 * do not infer public types
* disable incremental builds for public type generation. They generate non-deterministic types microsoft/rushstack#1958 * do not infer public types
Summary
tscwith incremental builds enabled generates non-deterministic types microsoft/rushstack#1958To make resulting API docs predictable, I did:
@elastic/kibana-app-arch FYI