Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Design/UI improvements #76946

Merged
merged 27 commits into from
Sep 23, 2020
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
59b7ec8
UI tweaks
chrisronline Aug 25, 2020
a0fdc44
Merge remote-tracking branch 'elastic/master' into monitoring/ui
chrisronline Aug 31, 2020
19926cc
Add more page titles
chrisronline Sep 2, 2020
5bf97fc
Merge remote-tracking branch 'elastic/master' into monitoring/ui
chrisronline Sep 8, 2020
e544af6
Respect pagination settings
chrisronline Sep 8, 2020
5511653
Update snapshot
chrisronline Sep 8, 2020
4ad65ea
Fix loc issues
chrisronline Sep 8, 2020
72e794b
Merge remote-tracking branch 'elastic/master' into monitoring/ui
chrisronline Sep 14, 2020
b50e793
Merge remote-tracking branch 'elastic/master' into monitoring/ui
chrisronline Sep 15, 2020
efa901d
Update node listing
chrisronline Sep 15, 2020
69a4646
Fix tests
chrisronline Sep 15, 2020
dc69527
Update icon
chrisronline Sep 15, 2020
df4de05
Update jobs label
chrisronline Sep 15, 2020
c733fe6
More label changes
chrisronline Sep 15, 2020
c08dfe2
Fix tests
chrisronline Sep 15, 2020
640c04b
Fix tests
chrisronline Sep 16, 2020
6abdfa5
PR feedback
chrisronline Sep 16, 2020
9dcc403
Improve responsive design here
chrisronline Sep 16, 2020
a6425ae
PR feedback
chrisronline Sep 16, 2020
cffb241
Fix tests
chrisronline Sep 16, 2020
aef8056
Merge remote-tracking branch 'elastic/master' into monitoring/ui
chrisronline Sep 16, 2020
4853349
Fix test and i18n
chrisronline Sep 16, 2020
5ee2a22
Remove unused translations
chrisronline Sep 17, 2020
e6c3608
Merge remote-tracking branch 'elastic/master' into monitoring/ui
chrisronline Sep 17, 2020
e2480b6
Merge remote-tracking branch 'elastic/master' into monitoring/ui
chrisronline Sep 22, 2020
659c222
Fix tests
chrisronline Sep 22, 2020
494517d
Tweaks
chrisronline Sep 23, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions x-pack/plugins/monitoring/public/angular/app_modules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ import { licenseProvider } from '../services/license';
// @ts-ignore
import { titleProvider } from '../services/title';
// @ts-ignore
import { monitoringBeatsBeatProvider } from '../directives/beats/beat';
// @ts-ignore
import { monitoringBeatsOverviewProvider } from '../directives/beats/overview';
// @ts-ignore
import { monitoringMlListingProvider } from '../directives/elasticsearch/ml_job_listing';
// @ts-ignore
import { monitoringMainProvider } from '../directives/main';
Expand Down Expand Up @@ -153,8 +149,6 @@ function createMonitoringAppServices() {
function createMonitoringAppDirectives() {
angular
.module('monitoring/directives', [])
.directive('monitoringBeatsBeat', monitoringBeatsBeatProvider)
.directive('monitoringBeatsOverview', monitoringBeatsOverviewProvider)
.directive('monitoringMlListing', monitoringMlListingProvider)
.directive('monitoringMain', monitoringMainProvider);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ export function ApmServerInstance({ summary, metrics, ...props }) {

const charts = seriesToShow.map((data, index) => (
<EuiFlexItem style={{ minWidth: '45%' }} key={index}>
<EuiPanel>
<MonitoringTimeseriesContainer series={data} {...props} />
</EuiPanel>
<MonitoringTimeseriesContainer series={data} {...props} />
</EuiFlexItem>
));

Expand All @@ -55,15 +53,15 @@ export function ApmServerInstance({ summary, metrics, ...props }) {
<h1>
<FormattedMessage
id="xpack.monitoring.apm.instance.heading"
defaultMessage="APM Instance"
defaultMessage="APM server instance"
/>
</h1>
</EuiScreenReaderOnly>
<EuiPanel>
<Status stats={summary} />
</EuiPanel>
<EuiSpacer size="m" />
<EuiPageContent>
<EuiPanel>
<Status stats={summary} />
</EuiPanel>
<EuiSpacer size="m" />
<EuiFlexGroup wrap>{charts}</EuiFlexGroup>
</EuiPageContent>
</EuiPageBody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,11 @@ export function ApmServerInstances({ apms, setupMode }) {
/>
</h1>
</EuiScreenReaderOnly>
<EuiPanel>
<Status stats={data.stats} />
</EuiPanel>
<EuiSpacer size="m" />
<EuiPageContent>
<EuiPanel>
<Status stats={data.stats} />
</EuiPanel>
<EuiSpacer size="m" />
{setupModeCallout}
<EuiMonitoringTable
className="apmInstancesTable"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ export function ApmOverview({ stats, metrics, ...props }) {

const charts = seriesToShow.map((data, index) => (
<EuiFlexItem style={{ minWidth: '45%' }} key={index}>
<EuiPanel>
<MonitoringTimeseriesContainer series={data} {...props} />
</EuiPanel>
<MonitoringTimeseriesContainer series={data} {...props} />
</EuiFlexItem>
));

Expand All @@ -51,15 +49,15 @@ export function ApmOverview({ stats, metrics, ...props }) {
<h1>
<FormattedMessage
id="xpack.monitoring.apm.overview.heading"
defaultMessage="APM Overview"
defaultMessage="APM server overview"
/>
</h1>
</EuiScreenReaderOnly>
<EuiPanel>
<Status stats={stats} />
</EuiPanel>
<EuiSpacer size="m" />
<EuiPageContent>
<EuiPanel>
<Status stats={stats} />
</EuiPanel>
<EuiSpacer size="s" />
<EuiFlexGroup wrap>{charts}</EuiFlexGroup>
</EuiPageContent>
</EuiPageBody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ export function Beat({ summary, metrics, ...props }) {
<EuiPageBody>
<EuiPanel>
<SummaryStatus metrics={summarytStatsTop} data-test-subj="beatSummaryStatus01" />
</EuiPanel>
<EuiSpacer size="m" />
<EuiPanel>
<SummaryStatus metrics={summarytStatsBot} data-test-subj="beatSummaryStatus02" />
</EuiPanel>
<EuiSpacer size="m" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
EuiSpacer,
EuiLink,
EuiScreenReaderOnly,
EuiPanel,
} from '@elastic/eui';
import { Stats } from '../../beats';
import { formatMetric } from '../../../lib/format_number';
Expand Down Expand Up @@ -153,9 +154,11 @@ export class Listing extends PureComponent {
/>
</h1>
</EuiScreenReaderOnly>
<EuiPageContent>
<EuiPanel>
<Stats stats={stats} />
<EuiSpacer size="m" />
</EuiPanel>
<EuiSpacer size="m" />
<EuiPageContent>
{setupModeCallOut}
<EuiMonitoringTable
className="beatsTable"
Expand Down
Loading