Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Add inventory view timeline #77804

Merged
merged 23 commits into from
Sep 22, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Sep 17, 2020

Summary

Closes #73962
Screen Shot 2020-09-17 at 1 16 03 PM

  • Adds the timeline chart which, when open, makes a second /snapshot request for a non-groupBy'd data set with a longer lookback period (the second request is not made when the timeline chart is closed)
  • Sets timerange based on the waffle map's interval length
  • Modifies the /snapshot route to allow for a non-groupBy request
  • Updates some Snapshot metric text to comply with EUI
  • Moves some elements from the bottom action bar to the top to comply with ticket design specs

Checklist

Delete any items that are not applicable to this PR.

@Zacqary Zacqary added release_note:enhancement Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 labels Sep 17, 2020
@Zacqary Zacqary requested a review from a team as a code owner September 17, 2020 18:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary
Copy link
Contributor Author

Zacqary commented Sep 17, 2020

Clicking different points on the chart can be flaky. This is tracked in elastic/elastic-charts#748

@Zacqary
Copy link
Contributor Author

Zacqary commented Sep 21, 2020

@elasticmachine merge upstream

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM

const timeLengthResult = useMemo(() => getTimeLengthFromInterval(interval), [interval]);
const { timeLength, lookbackSize, intervalInSeconds } = timeLengthResult;

const timerange: InfraTimerangeInput = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to workaround the lookback limitation? If you just set the from, to, interval and then set ignoreLookback: true it would draw all the buckets without having to calculate the lookback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixing that

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
infra 1099 +3 1096

async chunks size

id value diff baseline
infra 3.9MB +126.4KB 3.8MB

page load bundle size

id value diff baseline
infra 277.3KB -26.0B 277.4KB

distributable file count

id value diff baseline
default 45924 -3 45927

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit a0f03dd into elastic:master Sep 22, 2020
@Zacqary Zacqary deleted the 73962-inventory-timeline branch September 22, 2020 21:21
Zacqary added a commit to Zacqary/kibana that referenced this pull request Sep 22, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Zacqary added a commit that referenced this pull request Sep 22, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 23, 2020
* master: (31 commits)
  skip tests for old pacakge (elastic#78194)
  [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872)
  [Lens] Rename "telemetry" to "stats" (elastic#78125)
  [CSM] Url search (elastic#77516)
  [Drilldowns] Config to disable URL Drilldown  (elastic#77887)
  [Lens] Combined histogram/range aggregation for numbers (elastic#76121)
  Remove legacy plugins support (elastic#77599)
  'Auto' interval must be correctly calculated for natural numbers (elastic#77995)
  [CSM] fix ingest data retry order messed up (elastic#78163)
  Add response status helpers (elastic#78006)
  Bump react-beautiful-dnd (elastic#78028)
  [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004)
  Index pattern  - refactor constructor (elastic#77791)
  Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192)
  Remove [key: string]: any; from IIndexPattern (elastic#77968)
  Remove requirement for manage_index_templates privilege for Index Management (elastic#77377)
  [Ingest Manager] Agent bulk actions UI (elastic#77690)
  [Metrics UI] Add inventory view timeline (elastic#77804)
  Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101)
  Update to latest rum-react (elastic#78193)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Inventory view timeline
5 participants