Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix service maps ML link zoom value #77841

Merged
merged 3 commits into from
Sep 21, 2020

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Sep 18, 2020

Closes #76372 by removing the zoom query param from the ml time series explorer link

@ogupte ogupte requested a review from a team as a code owner September 18, 2020 00:47
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte
Copy link
Contributor Author

ogupte commented Sep 21, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 5.0MB -20.0B 5.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit fa3ee11 into elastic:master Sep 21, 2020
ogupte added a commit to ogupte/kibana that referenced this pull request Sep 21, 2020
* Closes elastic#76372 by removing the `zoom` query param from the ml time series explorer link

* updated test snapshot for updated ML link href

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
ogupte added a commit that referenced this pull request Sep 21, 2020
* Closes #76372 by removing the `zoom` query param from the ml time series explorer link

* updated test snapshot for updated ML link href

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@smith
Copy link
Contributor

smith commented Oct 21, 2020

Tests ok. No zoom in URL.

@smith smith added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan release_note:fix Team:APM All issues that need APM UI Team support v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Service Map view anomaly link using wrong zoom value
5 participants