Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Ingest setup upgrade #78081

Merged
merged 30 commits into from
Sep 28, 2020
Merged

[Ingest Manager] Ingest setup upgrade #78081

merged 30 commits into from
Sep 28, 2020

Commits on Sep 17, 2020

  1. Adding bulk upgrade api

    @jonathan-buttner
    jonathan-buttner committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    76df74d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Addressing comments

    @jonathan-buttner
    jonathan-buttner committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    6dea606 View commit details
    Browse the repository at this point in the history

  2. Removing todo

    @jonathan-buttner
    jonathan-buttner committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    268c526 View commit details
    Browse the repository at this point in the history

  3. Resolving conflicts

    @jonathan-buttner
    jonathan-buttner committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    04a39bd View commit details
    Browse the repository at this point in the history

  4. Changing body field

    @jonathan-buttner
    jonathan-buttner committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    f111406 View commit details
    Browse the repository at this point in the history

  5. Adding helper for getting the bulk install route

    @jonathan-buttner
    jonathan-buttner committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    2846b76 View commit details
    Browse the repository at this point in the history

  6. Adding request spec

    @jonathan-buttner
    jonathan-buttner committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    20357fd View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Pulling in Johns changes

    @jonathan-buttner
    jonathan-buttner committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    9b29802 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into ingest-bulk-u… 

    …pgrade
    @jonathan-buttner
    jonathan-buttner committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    3d2a686 View commit details
    Browse the repository at this point in the history

  3. Removing test for same package upgraded multiple times

    @jonathan-buttner
    jonathan-buttner committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    7cb80e9 View commit details
    Browse the repository at this point in the history

  4. Adding upgrade to setup route

    @jonathan-buttner
    jonathan-buttner committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    6e333ab View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Fixing merge conflicts

    @jonathan-buttner
    jonathan-buttner committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    99f6aee View commit details
    Browse the repository at this point in the history

  2. Adding setup integration test

    @jonathan-buttner
    jonathan-buttner committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    8a41396 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Clean up error handling

    @jonathan-buttner
    jonathan-buttner committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    219cfa9 View commit details
    Browse the repository at this point in the history

  2. Beginning to add tests

    @jonathan-buttner
    jonathan-buttner committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    ba00737 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:elastic/kibana into ingest-setup-… 

    …upgrade
    @jonathan-buttner
    jonathan-buttner committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    267931b View commit details
    Browse the repository at this point in the history

  4. Failing jest mock tests

    @jonathan-buttner
    jonathan-buttner committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    037ba98 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. Break up tests & modules for easier testing. 

    Deal with issue described in jestjs/jest#1075 (comment)

epm/packages/install has functions a, b, c which are independent but a can also call b and c

function a() {
  b();
  c();
}

The linked FB issue describes the cause and rationale (Jest works on "module" boundary) but TL;DR: it's easier if you split up your files

Some related links I found during this journey

 * https://medium.com/@qjli/how-to-mock-specific-module-function-in-jest-715e39a391f4
  * https://stackoverflow.com/questions/52650367/jestjs-how-to-test-function-being-called-inside-another-function
   * https://stackoverflow.com/questions/50854440/spying-on-an-imported-function-that-calls-another-function-in-jest/50855968#50855968
    John Schulz committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    a76006f View commit details
    Browse the repository at this point in the history

  2. Add test confirming update error result will throw

    John Schulz committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    5c259d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Keep orig error. Add status code in http handler

    John Schulz committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    06cfadc View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Leave error as-is

    John Schulz committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    a3c77ce View commit details
    Browse the repository at this point in the history

  2. Removing accidental code changes. File rename.

    John Schulz committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    25c3cd0 View commit details
    Browse the repository at this point in the history

  3. Missed a function when moving to a new file

    John Schulz committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    202b7a2 View commit details
    Browse the repository at this point in the history

  4. Add missing type imports

    John Schulz committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    ee4c774 View commit details
    Browse the repository at this point in the history

  5. Lift .map lambda into named outer function

    John Schulz committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    c906aea View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. Merge pull request #7 from jfsiii/ingest-setup-upgrade 

    Ingest setup upgrade
    @jonathan-buttner
    jonathan-buttner authored Sep 28, 2020
    Configuration menu
    Copy the full SHA
    11b677d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:elastic/kibana into ingest-setup-… 

    …upgrade
    @jonathan-buttner
    jonathan-buttner committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    4afbb56 View commit details
    Browse the repository at this point in the history

  3. Adding additional test

    @jonathan-buttner
    jonathan-buttner committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    3f8295d View commit details
    Browse the repository at this point in the history

  4. Fixing type error

    @jonathan-buttner
    jonathan-buttner committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    7f02b5f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ingest-setup-upgrade

    @elasticmachine
    elasticmachine authored Sep 28, 2020
    Configuration menu
    Copy the full SHA
    0427b9d View commit details
    Browse the repository at this point in the history