Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust extend_es_archiver to handle additional cases #79308

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Oct 2, 2020

Summary

This PR enables the extend_es_archiver to recognize additional indices like .kibana_1 as well as a list of indices.

Details

During functional tests, there are cases where the Kibana default settings are not applied correctly after loading an esArchive. This happens when the archive works on a .kibana_<N> index. As a result e.g. the timezone is not set to UTC any more, which can make tests fail in case the server and client are in different time zones (happens on some cloud tests depending on cloud region).
Also, the esArchiver stats output can contain a list of indices as a key, here's one example of the stats when loading lens/basic, that's not triggering the update to default settings:

{
    '.kibana_2,.kibana_1': {
        skipped: false,
        deleted: true,
        created: false,
        archived: false,
        waitForSnapshot: 0,
        configDocs: { upgraded: 0, tagged: 0, upToDate: 0 },
        docs: { indexed: 0, archived: 0 },
    },
    '.kibana_1': {
        skipped: false,
        deleted: false,
        created: true,
        archived: false,
        waitForSnapshot: 0,
        configDocs: { upgraded: 0, tagged: 0, upToDate: 0 },
        docs: { indexed: 11, archived: 0 },
    },
};

@pheyos pheyos added test_infra v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 2, 2020
@pheyos pheyos self-assigned this Oct 2, 2020
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit 819ccf1 into elastic:master Oct 2, 2020
@pheyos pheyos deleted the fix_extend_es_archiver branch October 2, 2020 18:14
pheyos added a commit to pheyos/kibana that referenced this pull request Oct 2, 2020
This PR enables the extend_es_archiver to recognize additional indices like .kibana_1 as well as a list of indices.
pheyos added a commit that referenced this pull request Oct 2, 2020
This PR enables the extend_es_archiver to recognize additional indices like .kibana_1 as well as a list of indices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes test_infra v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants