Implemented trusted app name truncation. #79976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efreeti
added
v8.0.0
release_note:skip
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
|
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
kevinlog
reviewed
Oct 8, 2020
| @@ -35,7 +35,7 @@ export const GetTrustedAppsRequestSchema = { | |||
|
|
|||
| export const PostTrustedAppCreateRequestSchema = { | |||
| body: schema.object({ | |||
| name: schema.string({ minLength: 1 }), | |||
| name: schema.string({ minLength: 1, maxLength: 256 }), | |||
There was a problem hiding this comment.
after some more thought, we could actually make this even shorter since it's just a name, however I don't think it will be likely that users actually create long trusted names.
I can also see from your screenshots that the table still truncates on a single line which is most important in regards to the look of the the feature, so I'm good with this as is.
kevinlog
approved these changes
Oct 8, 2020
efreeti
added a commit
to efreeti/kibana
that referenced
this pull request
Oct 8, 2020
efreeti
added a commit
to efreeti/kibana
that referenced
this pull request
Oct 8, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 8, 2020
* master: [ML] Fix job selection flyout (elastic#79850) Removed visualization:loadingDelay (elastic#79841) [Alerts] fix failing executionStatus function test with null deref (elastic#79809) Implemented trusted app name truncation. (elastic#79976)
efreeti
added a commit
that referenced
this pull request
Oct 8, 2020
efreeti
added a commit
that referenced
this pull request
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented trusted app name truncation in the table and in the card. Also added limit to the name length when entering in the create form.
Checklist