Warning on required prop sorting.sort.direction on Vis Editor Table
#80100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DianaDerevyankina
added
Feature:Vis Editor
alexwizp
reviewed
Oct 9, 2020
| defaultMessage: 'Actions', | ||
| }), | ||
| name: actionsColumnName, | ||
| field: actionsColumnName, |
There was a problem hiding this comment.
I prefer to fix that issue on Elastic UI side. field param is not required for ActionsColumn (see https://elastic.github.io/eui/#/tabular-content/in-memory-tables). From my point of view ActionsColumn's should be ignored by default for sorting
There was a problem hiding this comment.
@chandlerprall any ideas? Should we move that fix to Elastic UI side?
There was a problem hiding this comment.
Agreed, please create an issue in https://github.com/elastic/eui and we'll take a look.
|
@chandlerprall Could you check the PR created in eui repo, please? elastic/eui#4138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69657
Summary
Added field to
Actionscolumn to avoid setting this column name as sort name in EuiInMemoryTable.Checklist
Delete any items that are not applicable to this PR.
For maintainers