Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes for anomaly swim lane #80299

Merged
merged 6 commits into from
Oct 13, 2020
Merged

[ML] Fixes for anomaly swim lane #80299

merged 6 commits into from
Oct 13, 2020

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Oct 13, 2020 •
edited
Loading

Summary

  • Fixes the brushing mask for dark theme
    image
  • Fixes cell selection caused a rollback of the global date picker
  • Fixes interval for explorer page and embeddable. Previously, the swim lane selection callback was excluding the right boundary of the time range, and later on, the resolver was extending it with an interval. New swim lane provides actual time boundaries so there is no need to append the interval to the range anymore.

Checklist

@darnautov darnautov added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 labels Oct 13, 2020
@darnautov darnautov requested a review from a team as a code owner October 13, 2020 08:59
@darnautov darnautov self-assigned this Oct 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

walterra
walterra approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@peteharverson
Copy link
Contributor

If I open the Anomaly Explorer for a job, select a cell in the Overall swimlane, then do a full browser refresh, the page never reloads correctly, with an error shown in the console:

image

Is this caused the issue caused by false being passed for size for bucket_sort from the swim lane?

@peteharverson peteharverson mentioned this pull request Oct 13, 2020
Merged
@darnautov
Copy link
Contributor Author

If I open the Anomaly Explorer for a job, select a cell in the Overall swimlane, then do a full browser refresh, the page never reloads correctly, with an error shown in the console:

image

Is this caused the issue caused by false being passed for size for bucket_sort from the swim lane?

Fixed in 066d0b9

@walterra
Copy link
Contributor

Did a local test and can confirm latest changes fix the issue Pete found.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ml 11.2MB 11.3MB +13.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peteharverson
peteharverson approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits and LGTM

@darnautov darnautov merged commit f453467 into elastic:master Oct 13, 2020
@darnautov darnautov deleted the ML-swim-lane-fixes branch October 13, 2020 14:54
This was referenced Oct 13, 2020
Merged
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Oct 13, 2020
@darnautov
[ML] Fixes for anomaly swim lane (elastic#80299)
adc9ebe 
* [ML] add swim lane styles for dark theme

* [ML] fix global time range update on sell selection

* [ML] fix getSelectionTimeRange

* [ML] fix range selection for embeddable

* [ML] fix job selection

* [ML] fix swim lane limit
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 13, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/migrate-h…
200b6d4 
…otphase-to-formlib

* 'master' of github.com:elastic/kibana: (59 commits)
  [Security Solution][Resolver] Replace copy-to-clipboard with native navigator.clipboard (elastic#80193)
  [Security Solution] Reduce initial bundle size (elastic#78992)
  [Security Solution][Resolver] Fix Resize node box-shadow bug (elastic#80223)
  Move observability content (elastic#79978)
  skip flaky suite (elastic#79389)
  removing kibana_datatable` in favor of `datatable` (elastic#75184)
  [ML] Fixes for anomaly swim lane  (elastic#80299)
  [Lens] Smokescreen lens test unskip (elastic#80190)
  Improved AlertsClient tests structure by splitting a huge alerts_client.tests.ts file into a specific files defined by its responsibility. (elastic#80088)
  [APM] React key warning when opening popover with external resources (elastic#80328)
  [Step 1] use Observables on server search API (elastic#79874)
  Apply back pressure in Task Manager whenever Elasticsearch responds with a 429 (elastic#75666)
  [Lens] Leverage original http request error (elastic#79831)
  [Security Solution][Case] Improve ServiceConnectorCaseParams type (elastic#80109)
  [SECURITY_SOLUTION] Fix query on alert histogram (elastic#80219)
  [DOCS] Update ingest node pipelines doc (elastic#79187)
  [Ingest Manager] Split up OpenAPI spec file  (elastic#80107)
  [SECURITY_SOLUTION][ENDPOINT] Fix label on Trusted App create name field (elastic#80001)
  [Ingest Manager] Fix agent policy bump revision to create only one POLICY_CHANGE action (elastic#80081)
  Grid layout fixes (elastic#80305)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/data_tier_allocation_field.tsx
#	x-pack/plugins/index_lifecycle_management/public/shared_imports.ts
darnautov added a commit that referenced this pull request Oct 13, 2020
@darnautov
[ML] Fixes for anomaly swim lane (#80299) (#80356)
371dc15 
* [ML] add swim lane styles for dark theme

* [ML] fix global time range update on sell selection

* [ML] fix getSelectionTimeRange

* [ML] fix range selection for embeddable

* [ML] fix job selection

* [ML] fix swim lane limit
darnautov added a commit that referenced this pull request Oct 13, 2020
@darnautov
[ML] Fixes for anomaly swim lane (#80299) (#80357)
9fd8212 
* [ML] add swim lane styles for dark theme

* [ML] fix global time range update on sell selection

* [ML] fix getSelectionTimeRange

* [ML] fix range selection for embeddable

* [ML] fix job selection

* [ML] fix swim lane limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darnautov @elasticmachine @peteharverson @walterra @kibanamachine