-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Don't error if editing the same agent_policy #80403
[Ingest Manager] Don't error if editing the same agent_policy #80403
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
@jen-huang (maybe @EricDavisX ) would you mind checking this out locally and using the UI to check? Assuming that works for you and the CI passes, I'd like to get merge this ASAP so we can possibly get it in before the BC is cut tomorrow. I can follow up with tests, but since it's critical I'd really like to get something in the BC. Thanks. |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce the error, and verified that this change fixes it. 👍
## Summary fixes elastic#80136 Haven't added/updated tests yet but tested the various combinations in the UI and all worked as expected. <details><summary>Screenshots</summary> <h3>Policy listing</h3> <img width="1302" alt="Screen Shot 2020-10-14 at 7 05 19 AM" src="https://user-images.githubusercontent.com/57655/95981056-1c1c6d00-0dec-11eb-9746-5e91043f3d19.png"> <h3>Update existing policy succeeds</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 05 49 AM" src="https://user-images.githubusercontent.com/57655/95981059-1cb50380-0dec-11eb-9e55-7a14b72085f9.png"> <h3>Creating new policy w/existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 06 06 AM" src="https://user-images.githubusercontent.com/57655/95981062-1cb50380-0dec-11eb-833b-1ab6636a5c67.png"> <h3>Updating policy to existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 08 05 AM" src="https://user-images.githubusercontent.com/57655/95981078-1f175d80-0dec-11eb-91d5-7ffd976da48e.png"> </details> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…0502) ## Summary fixes #80136 Haven't added/updated tests yet but tested the various combinations in the UI and all worked as expected. <details><summary>Screenshots</summary> <h3>Policy listing</h3> <img width="1302" alt="Screen Shot 2020-10-14 at 7 05 19 AM" src="https://user-images.githubusercontent.com/57655/95981056-1c1c6d00-0dec-11eb-9746-5e91043f3d19.png"> <h3>Update existing policy succeeds</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 05 49 AM" src="https://user-images.githubusercontent.com/57655/95981059-1cb50380-0dec-11eb-9e55-7a14b72085f9.png"> <h3>Creating new policy w/existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 06 06 AM" src="https://user-images.githubusercontent.com/57655/95981062-1cb50380-0dec-11eb-833b-1ab6636a5c67.png"> <h3>Updating policy to existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 08 05 AM" src="https://user-images.githubusercontent.com/57655/95981078-1f175d80-0dec-11eb-91d5-7ffd976da48e.png"> </details> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This needs a backport to 7.x too 🙂 |
## Summary fixes elastic#80136 Haven't added/updated tests yet but tested the various combinations in the UI and all worked as expected. <details><summary>Screenshots</summary> <h3>Policy listing</h3> <img width="1302" alt="Screen Shot 2020-10-14 at 7 05 19 AM" src="https://user-images.githubusercontent.com/57655/95981056-1c1c6d00-0dec-11eb-9746-5e91043f3d19.png"> <h3>Update existing policy succeeds</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 05 49 AM" src="https://user-images.githubusercontent.com/57655/95981059-1cb50380-0dec-11eb-9e55-7a14b72085f9.png"> <h3>Creating new policy w/existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 06 06 AM" src="https://user-images.githubusercontent.com/57655/95981062-1cb50380-0dec-11eb-833b-1ab6636a5c67.png"> <h3>Updating policy to existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 08 05 AM" src="https://user-images.githubusercontent.com/57655/95981078-1f175d80-0dec-11eb-91d5-7ffd976da48e.png"> </details> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…0589) ## Summary fixes #80136 Haven't added/updated tests yet but tested the various combinations in the UI and all worked as expected. <details><summary>Screenshots</summary> <h3>Policy listing</h3> <img width="1302" alt="Screen Shot 2020-10-14 at 7 05 19 AM" src="https://user-images.githubusercontent.com/57655/95981056-1c1c6d00-0dec-11eb-9746-5e91043f3d19.png"> <h3>Update existing policy succeeds</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 05 49 AM" src="https://user-images.githubusercontent.com/57655/95981059-1cb50380-0dec-11eb-9e55-7a14b72085f9.png"> <h3>Creating new policy w/existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 06 06 AM" src="https://user-images.githubusercontent.com/57655/95981062-1cb50380-0dec-11eb-833b-1ab6636a5c67.png"> <h3>Updating policy to existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 08 05 AM" src="https://user-images.githubusercontent.com/57655/95981078-1f175d80-0dec-11eb-91d5-7ffd976da48e.png"> </details> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Summary
fixes #80136
Haven't added/updated tests yet but tested the various combinations in the UI and all worked as expected.
Screenshots
Policy listing
Update existing policy succeeds
Creating new policy w/existing name fails
Updating policy to existing name fails