[data.ui] Fix flaky test & lazy loading rendering artifacts. #80612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
release_note:skip
lukeelmers
commented
Oct 15, 2020
Comment on lines
+44
to
+45
| jest.mock('../query_string_input/query_bar_top_row', () => { | ||
| return () => <div className="queryBar" />; |
There was a problem hiding this comment.
This was the only substantive change in this file; all other changes are pretty much reverting to the original state of the test before #78889 was merged.
lukeelmers
force-pushed
the
fix/lazy-ui
branch
from
36bb88d
to
42669cd
Compare
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
spalger
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Code LGTM, though I'm not familiar with this part of the code. If you'd like to get more confidence that this fixes flakiness then I recommend running one of the previously flaky ciGroups a few hundred times in the flaky test runner
mattkime
approved these changes
Oct 15, 2020
I can't use flaky test runner since this is a jest test, but I did run the test in a loop a few hundred times and everything came back green. I'll also re-run CI another time before merging for good measure. |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunk count
async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Oct 15, 2020
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Oct 15, 2020
…#80612) # Conflicts: # src/plugins/data/public/ui/index_pattern_select/index.tsx
lukeelmers
added a commit
that referenced
this pull request
Oct 16, 2020
lukeelmers
added a commit
that referenced
this pull request
Oct 16, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 16, 2020
* master: (115 commits) [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618) added brace import to vis editor (elastic#80652) Fix error rate sorting in services list (elastic#80764) Emit info log when using custom registry URL (elastic#80768) [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766) Add Storybook a11y addon (elastic#80069) Fix anomaly alert selection text (elastic#80746) [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208) [kbn/optimizer] tweak split chunks options (elastic#80444) update template to use the new team label (elastic#80748) [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718) Adjusts observability alerting perms to require "all" (elastic#79896) [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists (elastic#80592) [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612) Licensed feature usage for connectors (elastic#77679) [Security Solution] Cypress template creation (elastic#80180) [APM] Hide service if only data is from ML (elastic#80145) Fix role mappings test for ESS (elastic#80604) [Maps] Add support for envelope (elastic#80614) [Security Solution] Update button text according to status (elastic#80389) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79910
In #78889 we split up the components provided by the data plugin to be lazy-loaded via
React.lazy. As a result, some flakiness emerged in the<SearchBar />unit tests as shown in #79910.Additionally, the fallback UI that was used in that PR included a loader which caused some weird rendering as you waited for the component to be loaded asynchronously. This caused some "dancing" behavior as seen in this screen grab from the SIEM app:
This PR addresses both of the above issues as follows:
SearchBar(which is lazy-loaded) didn't also lazy load the sub-components it relied on. Then in the unit test we import the non-lazy version ofSearchBardirectly, thus avoiding the async issues which I believe were contributing to the flakiness.Merging this bugfix for 7.10 as it handles a regression which would otherwise be released.