Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage collection plugins to ts project refs #81090

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Oct 20, 2020

Extracts usage_collection, telemetry and telemetry_collection_manager plugins to separate ts projects.
usage_collection is a blocker to a number of other plugins and needed to be handled first.
Part of #81017

Condensed output from node --max-old-space-size=4096 ./node_modules/.bin/tsc -p tsconfig.json --extendedDiagnostics --noEmit given in the after section for each plugin.

Before:
Files: 5411
Lines: 716853

After exporting plugins:
Usage Collection:
Files: 5365
Lines: 714437

Telemetry Collection Manager
Files: 5350
Lines: 713350

Telemetry
Files: 5279
Lines: 706662

@TinaHeiligers TinaHeiligers marked this pull request as ready for review October 20, 2020 14:44
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner October 20, 2020 14:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit e7f3044 into elastic:master Oct 20, 2020
@TinaHeiligers TinaHeiligers deleted the usage-collection-plugins-to-ts-project-refs branch October 20, 2020 16:32
TinaHeiligers added a commit that referenced this pull request Oct 20, 2020
@lukeelmers lukeelmers added Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants