[Resolver] Enable resolver test plugin tests #81339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oatkiller
force-pushed
the
enable-resolver-test-plugin-tests
branch
from
aab31ff
to
38bc12a
Compare
oatkiller
added
Feature:Resolver
|
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
oatkiller
added
the
release_note:skip
oatkiller
commented
Oct 21, 2020
| @@ -28,7 +28,8 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) { | |||
| // list paths to the files that contain your plugins tests | |||
| testFiles: [ | |||
| resolve(__dirname, './test_suites/resolver'), | |||
| resolve(__dirname, './test_suites/global_search'), | |||
| // Disabling this suite as it is broken. | |||
| // resolve(__dirname, './test_suites/global_search'), | |||
There was a problem hiding this comment.
@pgayvallet @myasonik @ryankeairns @cchaos This PR would disable the global_search suite (it is currently broken) and enable the entire x-pack/test/plugin_functional config. Is that OK with y'all? Thank you
There was a problem hiding this comment.
GlobalSearch API
GlobalSearchBar
basically works:
Error: expected 0 to equal 15
Seems only this test is failing, could you add a skip on the root describe in x-pack/test/plugin_functional/test_suites/global_search/global_search_bar.ts instead?
There was a problem hiding this comment.
And add a comment referencing #81397. Thank you
There was a problem hiding this comment.
Seems you got other failures from the suite. Forget that, just skip the whole suite.
jonathan-buttner
approved these changes
Oct 21, 2020
michaelolo24
approved these changes
Oct 21, 2020
bkimmel
approved these changes
Oct 21, 2020
oatkiller
force-pushed
the
enable-resolver-test-plugin-tests
branch
3 times, most recently
from
a98528a
to
d3f1629
Compare
added 8 commits
October 27, 2020 17:12
oatkiller
force-pushed
the
enable-resolver-test-plugin-tests
branch
from
d3f1629
to
50d44e7
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
oatkiller
pushed a commit
to oatkiller/kibana
that referenced
this pull request
Oct 28, 2020
Resolver has a test plugin. It can be found in `x-pack/tests/plugin_functional`. You can try it out like this: ``` yarn start --plugin-path x-pack/test/plugin_functional/plugins/resolver_test/ ``` This PR enables automated tests for the test plugin. This ensures that the test plugin will render.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 29, 2020
…kibana into alerts/convert-to-tm-intervals * 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits) fixed jest APM Experiments settings (elastic#81554) [Resolver] Enable resolver test plugin tests (elastic#81339) Add TS project references for inspector (elastic#81792) Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835) [Fleet] Rename ingestManager translations fleet (elastic#81837) [Logs UI] Transmit and render array field values in log entries (elastic#81385) Audit Logging: use the original url (elastic#81282) [User experience] Fix JS error rate (elastic#81512) [UX] Add median/percentile info in titles (elastic#79824) Support export for SO with circular refs (elastic#81582) Get rid of global types (elastic#81739) [APM] Fix precommit script (elastic#81594) skips overview tests (elastic#81877) [Security Solution][Case] Fix connector's labeling (elastic#81824) Added simple test, which only covers successful case when edit happened right after task was complete previous execution [Maps] Fix EMS test (elastic#81856) [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783) skip flaky suite (elastic#81853) Fixed type checks and unit tests ...
oatkiller
pushed a commit
that referenced
this pull request
Oct 29, 2020
Resolver has a test plugin. It can be found in `x-pack/tests/plugin_functional`. You can try it out like this: ``` yarn start --plugin-path x-pack/test/plugin_functional/plugins/resolver_test/ ``` This PR enables automated tests for the test plugin. This ensures that the test plugin will render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolver has a test plugin. It can be found in
x-pack/tests/plugin_functional. You can try it out like this:This PR enables automated tests for the test plugin. This ensures that the test plugin will render.
Screenshots
The navigation item for the test plugin:
The Resolver test plugin. It uses in-memory mocks for the data.
Checklist
Delete any items that are not applicable to this PR.
For maintainers