Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User experience] Enhance page load duration metrics #81915

Merged
merged 5 commits into from
Oct 29, 2020

Conversation

Kerry350
Copy link
Contributor

Summary

This PR implements the changes in #81636 (comment), and the further suggestions from #81636 (comment).

Screenshot 2020-10-28 at 16 02 48

@Kerry350 Kerry350 added v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v7.11 labels Oct 28, 2020
@Kerry350 Kerry350 requested review from shahzad31 and a team October 28, 2020 16:06
@Kerry350 Kerry350 self-assigned this Oct 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@Kerry350 Kerry350 added the release_note:skip Skip the PR/issue when compiling release notes label Oct 28, 2020
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quick work

WFG, you probably need to update few tests.

@Kerry350
Copy link
Contributor Author

Kerry350 commented Oct 28, 2020

@shahzad31 Thanks for the review 🙏

Yeah, I'm trying to fix the tests. Will have to wait until tomorrow now, as I need to speak to someone about getting e2e tests working locally 😬

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 3.3MB 3.3MB +5.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Kerry350 Kerry350 merged commit 667ff6c into elastic:master Oct 29, 2020
Kerry350 added a commit to Kerry350/kibana that referenced this pull request Oct 29, 2020
* Enhance page load duration metrics and helper tooltips
Kerry350 added a commit to Kerry350/kibana that referenced this pull request Oct 29, 2020
* Enhance page load duration metrics and helper tooltips
Kerry350 added a commit that referenced this pull request Oct 29, 2020
* Enhance page load duration metrics and helper tooltips
Kerry350 added a commit that referenced this pull request Oct 29, 2020
* Enhance page load duration metrics and helper tooltips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants