-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Convert migration guide to asciidoc #82600
Conversation
Pinging @elastic/kibana-platform (Team:Platform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a lot of comments 😅 but I think it's worth spending a bit of extra effort on these public docs.
docs/developer/architecture/kibana-platform-plugin-api.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/architecture/kibana-platform-plugin-api.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/architecture/kibana-platform-plugin-api.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/architecture/kibana-platform-plugin-api.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Initial conversion to asciidoc * Update and split migration guide * Convert MIGRATION_EXAMPLES to asciidoc * build with --focus flag * convert migration guide to asciidoc * cleanup migration_examples * fix wrong Heading size * update links in docs * Apply suggestions from code review Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> * Apply suggestions from code review Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> * add tooling section * explain purpose of each lifecycle method * cleanup docs * cleanup p2 * fix wrong link * resturcture core docs * fix wrong link * update missing links * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * address comments * add a commenta about plugin-helpers preconfigured * improve density of tables * fix lik * remove links to the migration guide * address comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * address @gchaps comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * change format of ES client change list Co-authored-by: Josh Dover <me@joshdover.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> # Conflicts: # docs/developer/architecture/core/saved-objects-service.asciidoc # docs/developer/architecture/index.asciidoc # src/core/MIGRATION.md # src/core/README.md
* Initial conversion to asciidoc * Update and split migration guide * Convert MIGRATION_EXAMPLES to asciidoc * build with --focus flag * convert migration guide to asciidoc * cleanup migration_examples * fix wrong Heading size * update links in docs * Apply suggestions from code review Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> * Apply suggestions from code review Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> * add tooling section * explain purpose of each lifecycle method * cleanup docs * cleanup p2 * fix wrong link * resturcture core docs * fix wrong link * update missing links * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * address comments * add a commenta about plugin-helpers preconfigured * improve density of tables * fix lik * remove links to the migration guide * address comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * address @gchaps comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * change format of ES client change list Co-authored-by: Josh Dover <me@joshdover.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> # Conflicts: # docs/developer/architecture/core/saved-objects-service.asciidoc # docs/developer/architecture/index.asciidoc # src/core/MIGRATION.md # src/core/README.md
* Initial conversion to asciidoc * Update and split migration guide * Convert MIGRATION_EXAMPLES to asciidoc * build with --focus flag * convert migration guide to asciidoc * cleanup migration_examples * fix wrong Heading size * update links in docs * Apply suggestions from code review Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> * Apply suggestions from code review Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> * add tooling section * explain purpose of each lifecycle method * cleanup docs * cleanup p2 * fix wrong link * resturcture core docs * fix wrong link * update missing links * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * address comments * add a commenta about plugin-helpers preconfigured * improve density of tables * fix lik * remove links to the migration guide * address comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * address @gchaps comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * change format of ES client change list Co-authored-by: Josh Dover <me@joshdover.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> # Conflicts: # docs/developer/architecture/core/saved-objects-service.asciidoc # docs/developer/architecture/index.asciidoc # src/core/MIGRATION.md # src/core/README.md
* Initial conversion to asciidoc * Update and split migration guide * Convert MIGRATION_EXAMPLES to asciidoc * build with --focus flag * convert migration guide to asciidoc * cleanup migration_examples * fix wrong Heading size * update links in docs * Apply suggestions from code review Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> * Apply suggestions from code review Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> * add tooling section * explain purpose of each lifecycle method * cleanup docs * cleanup p2 * fix wrong link * resturcture core docs * fix wrong link * update missing links * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * address comments * add a commenta about plugin-helpers preconfigured * improve density of tables * fix lik * remove links to the migration guide * address comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * address @gchaps comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * change format of ES client change list Co-authored-by: Josh Dover <me@joshdover.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> # Conflicts: # docs/developer/architecture/core/saved-objects-service.asciidoc # docs/developer/architecture/index.asciidoc # src/core/MIGRATION.md # src/core/README.md
The old link should still have a placeholder that link people to the correct place. There are links to the guide in the blog post that explains the new architecture. |
Summary
Closes #75786
This PR: