Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Convert migration guide to asciidoc #82600

Merged
merged 36 commits into from
Nov 24, 2020
Merged

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Nov 4, 2020

Summary

Closes #75786
This PR:

  • converts Migration & Migration_example guides to *.asciidoc
  • provides the minimal set of docs for the core services
  • adds links to core & plugin docs whenever possible
  • how to develop, build & install a plugin

@mshustov mshustov added docs Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 v8.0.0 labels Nov 4, 2020
@mshustov mshustov marked this pull request as ready for review November 4, 2020 14:44
@mshustov mshustov requested a review from a team as a code owner November 4, 2020 14:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov added the release_note:skip Skip the PR/issue when compiling release notes label Nov 5, 2020
@mshustov mshustov changed the title Convert migration guide to asciidoc [docs] Convert migration guide to asciidoc Nov 6, 2020
Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a lot of comments 😅 but I think it's worth spending a bit of extra effort on these public docs.

docs/developer/architecture/index.asciidoc Outdated Show resolved Hide resolved
docs/developer/architecture/core/core-api.asciidoc Outdated Show resolved Hide resolved
docs/developer/architecture/core/core-api.asciidoc Outdated Show resolved Hide resolved
docs/developer/architecture/core/core-api.asciidoc Outdated Show resolved Hide resolved
docs/developer/architecture/core/core-api.asciidoc Outdated Show resolved Hide resolved
docs/developer/architecture/core/core-api.asciidoc Outdated Show resolved Hide resolved
@mshustov mshustov requested a review from gchaps November 11, 2020 08:45
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
docs/developer/plugin/migrating-legacy-plugins.asciidoc Outdated Show resolved Hide resolved
@mshustov mshustov merged commit ab8a2f7 into elastic:master Nov 24, 2020
@mshustov mshustov deleted the pr/80784 branch November 24, 2020 08:46
mshustov added a commit to mshustov/kibana that referenced this pull request Nov 24, 2020
* Initial conversion to asciidoc

* Update and split migration guide

* Convert MIGRATION_EXAMPLES to asciidoc

* build with --focus flag

* convert migration guide to asciidoc

* cleanup migration_examples

* fix wrong Heading size

* update links in docs

* Apply suggestions from code review

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

* add tooling section

* explain purpose of each lifecycle method

* cleanup docs

* cleanup p2

* fix wrong link

* resturcture core docs

* fix wrong link

* update missing links

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* address comments

* add a commenta about plugin-helpers preconfigured

* improve density of tables

* fix lik

* remove links to the migration guide

* address comments

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* address @gchaps comments

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* change format of ES client change list

Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
# Conflicts:
#	docs/developer/architecture/core/saved-objects-service.asciidoc
#	docs/developer/architecture/index.asciidoc
#	src/core/MIGRATION.md
#	src/core/README.md
mshustov added a commit to mshustov/kibana that referenced this pull request Nov 24, 2020
* Initial conversion to asciidoc

* Update and split migration guide

* Convert MIGRATION_EXAMPLES to asciidoc

* build with --focus flag

* convert migration guide to asciidoc

* cleanup migration_examples

* fix wrong Heading size

* update links in docs

* Apply suggestions from code review

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

* add tooling section

* explain purpose of each lifecycle method

* cleanup docs

* cleanup p2

* fix wrong link

* resturcture core docs

* fix wrong link

* update missing links

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* address comments

* add a commenta about plugin-helpers preconfigured

* improve density of tables

* fix lik

* remove links to the migration guide

* address comments

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* address @gchaps comments

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* change format of ES client change list

Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
# Conflicts:
#	docs/developer/architecture/core/saved-objects-service.asciidoc
#	docs/developer/architecture/index.asciidoc
#	src/core/MIGRATION.md
#	src/core/README.md
mshustov added a commit that referenced this pull request Nov 24, 2020
* Initial conversion to asciidoc

* Update and split migration guide

* Convert MIGRATION_EXAMPLES to asciidoc

* build with --focus flag

* convert migration guide to asciidoc

* cleanup migration_examples

* fix wrong Heading size

* update links in docs

* Apply suggestions from code review

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

* add tooling section

* explain purpose of each lifecycle method

* cleanup docs

* cleanup p2

* fix wrong link

* resturcture core docs

* fix wrong link

* update missing links

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* address comments

* add a commenta about plugin-helpers preconfigured

* improve density of tables

* fix lik

* remove links to the migration guide

* address comments

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* address @gchaps comments

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* change format of ES client change list

Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
# Conflicts:
#	docs/developer/architecture/core/saved-objects-service.asciidoc
#	docs/developer/architecture/index.asciidoc
#	src/core/MIGRATION.md
#	src/core/README.md
mshustov added a commit that referenced this pull request Nov 24, 2020
* Initial conversion to asciidoc

* Update and split migration guide

* Convert MIGRATION_EXAMPLES to asciidoc

* build with --focus flag

* convert migration guide to asciidoc

* cleanup migration_examples

* fix wrong Heading size

* update links in docs

* Apply suggestions from code review

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

* add tooling section

* explain purpose of each lifecycle method

* cleanup docs

* cleanup p2

* fix wrong link

* resturcture core docs

* fix wrong link

* update missing links

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* address comments

* add a commenta about plugin-helpers preconfigured

* improve density of tables

* fix lik

* remove links to the migration guide

* address comments

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* address @gchaps comments

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* change format of ES client change list

Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
# Conflicts:
#	docs/developer/architecture/core/saved-objects-service.asciidoc
#	docs/developer/architecture/index.asciidoc
#	src/core/MIGRATION.md
#	src/core/README.md
@marius-dr
Copy link
Member

The old link should still have a placeholder that link people to the correct place. There are links to the guide in the blog post that explains the new architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.1 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write basic documentation for Kibana Development Platform
8 participants