-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workplace Search] Migrate SourceLogic from ent-search #83593
Merged
scottybollinger
merged 13 commits into
elastic:master
from
scottybollinger:scottybollinger/source-logic
Nov 18, 2020
Merged
[Workplace Search] Migrate SourceLogic from ent-search #83593
scottybollinger
merged 13 commits into
elastic:master
from
scottybollinger:scottybollinger/source-logic
Nov 18, 2020
Commits on Nov 17, 2020
-
Initial copy/paste of source logic
Only changed lodash imports and import order for linting
Configuration menu - View commit details
-
Copy full SHA for 5d6c3c6 - Browse repository at this point
Copy the full SHA 5d6c3c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82a1195 - Browse repository at this point
Copy the full SHA 82a1195View commit details -
Renamed IMeta -> Meta Used object instead of IObject
Configuration menu - View commit details
-
Copy full SHA for 174d244 - Browse repository at this point
Copy the full SHA 174d244View commit details -
Remove internal flash messages in favor of globals
- All instances of flashAPIErrors(e) are only placeholders until the later commit removing axios. - buttonLoading was set to false when the error flash messages were set. For now I added a `setButtonNotLoading` action to do this manually in a finally block. This will be refactored once axios is removed. - SourcesLogic is no longer needed because we set a queued flash message instead of trying to set it in SourcesLogic, which no longer has local flash messages
Configuration menu - View commit details
-
Copy full SHA for c5f6076 - Browse repository at this point
Copy the full SHA c5f6076View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddb64a1 - Browse repository at this point
Copy the full SHA ddb64a1View commit details -
According to the API info getSourceReConnectData is supposed to send the source ID and not the service type. In the template, we are actually sending the ID but the logic file parameterizes it as serviceType. This is fixed here. Usage: https://github.com/elastic/ent-search/blob/master/app/javascript/workplace_search/ContentSources/components/AddSource/ReAuthenticate.tsx#L38
Configuration menu - View commit details
-
Copy full SHA for 28b8942 - Browse repository at this point
Copy the full SHA 28b8942View commit details -
Also removes using history in favor of KibanaLogic’s navigateToUrl
Configuration menu - View commit details
-
Copy full SHA for e5a39cb - Browse repository at this point
Copy the full SHA e5a39cbView commit details -
This selector is actually an array of strings
Configuration menu - View commit details
-
Copy full SHA for d9b78db - Browse repository at this point
Copy the full SHA d9b78dbView commit details -
Create GenericObject to satisfy TypeScript
Previously in `ent-search`, we had a generic `IObject` interface that we could use on keyed objects. It was not migrated over since it uses `any` and Kibana has a generic `object` type we can use in most situations. However, when we are checking for keys in our code, `object` does not work. This commit is an attempt at making a generic interface we can use.
Configuration menu - View commit details
-
Copy full SHA for 7832179 - Browse repository at this point
Copy the full SHA 7832179View commit details -
Removes GenericObject from last commit and adds stricter local typing
Configuration menu - View commit details
-
Copy full SHA for 3cb5ad3 - Browse repository at this point
Copy the full SHA 3cb5ad3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70c5731 - Browse repository at this point
Copy the full SHA 70c5731View commit details
Commits on Nov 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4afbbef - Browse repository at this point
Copy the full SHA 4afbbefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62c7d15 - Browse repository at this point
Copy the full SHA 62c7d15View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.