Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Adds docs on how to run Kibana with the APM agent locally #84700

Merged
merged 12 commits into from
Dec 7, 2020

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Dec 1, 2020

Resolves #83045

Summary

Adds a section to the CONTRIBUTING docs on how to run Kibana locally with the APM agent.

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

For maintainers

@TinaHeiligers TinaHeiligers added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 1, 2020
@TinaHeiligers TinaHeiligers requested a review from a team December 1, 2020 19:26
@TinaHeiligers
Copy link
Contributor Author

@vigneshshanmugam I was asked to ping you for a review from the APM team.

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

[[running-kibana-with-apm]]
== Running Kibana with the APM Agent Locally

The easiest and recommended way of running Kibana with the APM agent locally is to use the solution provided by the https://github.com/elastic/apm-integration-testing[apm-integration-testing] repo. You’ll need https://www.docker.com/community-edition[Docker] and https://docs.docker.com/compose/install/[Docker Compose] to use the tool.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth adding a paragraph here about why a developer would want to do this with examples of the types of information that can be captured with the APM agent currently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ok?

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TinaHeiligers Looks good to me, But do you think its worth merging this section with already available debugging doc

https://github.com/elastic/kibana/blob/master/docs/developer/getting-started/debugging.asciidoc#instrumenting-with-elastic-apm

UI in {kib}.

If you want to run kibana with a local instance of the APM agent, refer to <<running-kibana-with-apm>>.
Copy link
Contributor Author

@TinaHeiligers TinaHeiligers Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment to reviewers: I've linked to the documentation on how to run Kibana with a local APM agent here.

----
module.exports = {
active: true,
serverUrl: 'http://127.0.0.1:8200', // use `http://localhost:8200` as an alternative
Copy link
Contributor Author

@TinaHeiligers TinaHeiligers Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment to reviewers: using http://127.0.0.1:8200 doesn't work for me, but localhost does. The apm-agent-node team is aware of this and working to find the cause.

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
Comment on lines +40 to +41
All config options can be set by
creating an appropriate config file under `config/apm.dev.js`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document that it is also possible to configure the agent via kibana.yml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgayvallet we can add that later, once we're ok with enabling in prod.

Copy link
Member

@sorenlouv sorenlouv Oct 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump: did we ever document this (and is it possible)? Asking because I want to add the apm settings to the allow list on cloud, to make it possible for anyone to enable apm instrumentation without involving cloud folks.

@TinaHeiligers TinaHeiligers merged commit 3604995 into elastic:master Dec 7, 2020
@TinaHeiligers TinaHeiligers deleted the running-kibana-with-apm branch December 7, 2020 19:39
TinaHeiligers added a commit that referenced this pull request Dec 7, 2020
#84700) (#85200)

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update apm documentation due to new configuration
5 participants