Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Case] Fix case status dropdown on modals #86243

Merged
merged 3 commits into from
Dec 23, 2020
Merged

[Security Solution][Case] Fix case status dropdown on modals #86243

merged 3 commits into from
Dec 23, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Dec 17, 2020 •
edited
Loading

Summary

Fixes the width of the status dropdown. Resolves: #85749.

Before:

Screenshot 2020-12-22 at 8 06 35 PM

After:

Screenshot 2020-12-22 at 8 07 05 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 17, 2020
@cnasikas cnasikas self-assigned this Dec 17, 2020
@cnasikas cnasikas requested review from a team as code owners December 17, 2020 08:38
@michaelolo24
Copy link
Contributor

When you have a chance, can you add an image of the before and after of the status dropdown to the PR?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +467.0B

Distributable file count

id before after diff
default 47144 47904 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit 21b34bc into elastic:master Dec 23, 2020
@cnasikas cnasikas deleted the fix/85749 branch December 23, 2020 07:36
This was referenced Dec 23, 2020
Merged
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Dec 23, 2020
@cnasikas
[Security Solution][Case] Fix case status dropdown on modals (elastic…
d953a70 
…#86243)
cnasikas added a commit to cnasikas/kibana that referenced this pull request Dec 23, 2020
@cnasikas
[Security Solution][Case] Fix case status dropdown on modals (elastic…
e452af9 
…#86243)
cnasikas added a commit that referenced this pull request Dec 23, 2020
@cnasikas
[7.11] [Security Solution][Case] Fix case status dropdown on modals (#…
7c1ba24 
…86243) (#86868)
cnasikas added a commit that referenced this pull request Dec 23, 2020
@cnasikas
[7.x] [Security Solution][Case] Fix case status dropdown on modals (#…
19a0119 
…86243) (#86867)
@oatkiller oatkiller added the Feature:Cases Cases feature label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

@cnasikas cnasikas

Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Count of In-progress is not displaying in select case pop up under the detection alert.
4 participants
@cnasikas @michaelolo24 @kibanamachine @oatkiller