Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] No data on the service transactions page renders blank screen #86640

Merged
merged 1 commit into from
Dec 22, 2020
Merged

[APM] No data on the service transactions page renders blank screen #86640

merged 1 commit into from
Dec 22, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #86618

After:
Screenshot 2020-12-21 at 13 53 44

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 21, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner December 21, 2020 12:59
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1735 1734 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB -458.0B

Distributable file count

id before after diff
default 47142 47902 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dgieselaar
dgieselaar reviewed Dec 21, 2020
View reviewed changes
x-pack/plugins/apm/public/selectors/throuput_chart_selectors.ts
throughputTimeseries[0].dataPoints[
throughputTimeseries[0].dataPoints.length - 1
].x;
return getEmptySeries(start, end);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we have this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before my change to split the charts API into latency and throughput APIs, when the tpmBuckets were empty it used the avg bucket to create an empty series, but it is not needed at all, Elastic charts will show the empty message when the series is equals to []. So we can just skip this and return the timeseries with empty data.

kibana/x-pack/plugins/apm/public/selectors/chart_selectors.ts

Lines 171 to 177 in b46655d

const { avg } = apmTimeseries.responseTimes;
if (!tpmBuckets.length && avg.length) {
const start = avg[0].x;
const end = avg[avg.length - 1].x;
return getEmptySeries(start, end);
}

dgieselaar
dgieselaar approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure I understand why we had it before and why it's no longer necessary.

@cauemarcondes cauemarcondes merged commit c4a8c68 into elastic:master Dec 22, 2020
@cauemarcondes cauemarcondes deleted the apm-blank-page branch December 22, 2020 08:34
@cauemarcondes cauemarcondes mentioned this pull request Dec 22, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Dec 22, 2020
@cauemarcondes
fixing blank page (elastic#86640)
b03fa69
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Dec 22, 2020
@cauemarcondes
fixing blank page (elastic#86640)
3f6087c
@cauemarcondes cauemarcondes mentioned this pull request Dec 22, 2020
Merged
cauemarcondes added a commit that referenced this pull request Dec 22, 2020
@cauemarcondes
[APM] No data on the service transactions page renders blank screen (#…
21f2739 
…86640) (#86725)
cauemarcondes added a commit that referenced this pull request Dec 22, 2020
@cauemarcondes
[APM] No data on the service transactions page renders blank screen (#…
634ce14 
…86640) (#86724)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 22, 2020
@gmmorris
Merge branch 'master' into alerts/typed-action-groups
d1e98eb 
* master: (36 commits)
  update apm index pattern (elastic#86739)
  [Visualizations] Remove vis_default_editor - visualize plugins cyclic dependencies (elastic#85422)
  [ML] Fix alignment of values in data frame analytics results view badges (elastic#86621)
  [Visualizations] Remove charts - editor plugins cyclic dependencies (elastic#84887)
  fixing blank page (elastic#86640)
  Update dependency vega to ^5.17.1 (elastic#86715)
  [Monitoring] Convert Kibana-related server files that read from _source to typescript (elastic#86364)
  Uses @elastic/elasticsearch-canary (elastic#86398)
  [CI] Removes script previously used for Karma (elastic#86412)
  [build] Remove grunt checkPlugins task (elastic#85852)
  [build] Remove grunt docker:docs task (elastic#85848)
  [ML] Add doc link for classification AUC ROC evaluation (elastic#86660)
  [ML] Edits saved object synchronization message (elastic#86664)
  Uses the new es client in canvas usage collector's fetch methods (elastic#86668)
  [ML] Support legacy watcher URL (elastic#86661)
  [ML] Fix Single Metric Viewer y domain extending beyond the visible focus area (elastic#86655)
  Migrates search telemetry usage collector es client from legacy to new (elastic#86597)
  [Alerting] Encourage type safe usage of Alerting (elastic#86623)
  Migrates kql_telemetry usage collector es client (elastic#86585)
  [ML] Fix time range adjustment for the swim lane causing the infinite loop update (elastic#86461)
  ...
@ogupte ogupte self-assigned this Jan 21, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees

@ogupte ogupte

Labels
apm:test-plan-7.11.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] No data on the service transactions page renders blank screen
6 participants
@cauemarcondes @elasticmachine @kibanamachine @dgieselaar @sorenlouv @ogupte