Sample data usage collector es client migration #86657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
Team:Core
TinaHeiligers
changed the title
TinaHeiligers
removed
the
Team:Core
|
Pinging @elastic/kibana-core-ui (Team:Core UI) |
TinaHeiligers
added
the
Team:Core
|
@elastic/kibana-core With the team changes that have happened recently, it turns out that Core actually owns most of what the Core-UI team used to own. The changes haven't been reflected in the |
TinaHeiligers
requested review from
Bamieh,
afharo and
a team
and removed request for
afharo and
Bamieh
afharo
approved these changes
Dec 22, 2020
| @@ -17,6 +17,7 @@ | |||
| * under the License. | |||
| */ | |||
|
|
|||
| import { SearchResponse } from 'elasticsearch'; | |||
There was a problem hiding this comment.
I think this should be imported from the new client @elastic/elasticsearch instead
There was a problem hiding this comment.
When I change the import location, my IDE errors with Module '"../../../../../../../node_modules/@elastic/elasticsearch"' has no exported member 'SearchResponse'.ts(2305)
Importing from src/core/server works though.
ryankeairns
approved these changes
Dec 22, 2020
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses the new elasticsearch client in the
sample_datausage collector.Part of #86358.
Checklist
Delete any items that are not applicable to this PR.
For maintainers