Remove dependency between alerts and infra #88342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alerts plugin was importing `JsonObject` from the infra plugin. The infra plugin imported `JsonObject`, `JsonValue`, and `JsonArray` from kibanaUtils and then re-exported them. Remove the re-export from the infra plugin and instead always import these types from kibanaUtils.
smith
added
v8.0.0
release_note:skip
patrykkopycinski
approved these changes
Jan 14, 2021
YulNaumenko
approved these changes
Jan 14, 2021
|
retest |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
weltenwort
approved these changes
Jan 15, 2021
smith
added a commit
to smith/kibana
that referenced
this pull request
Jan 15, 2021
The alerts plugin was importing `JsonObject` from the infra plugin. The infra plugin imported `JsonObject`, `JsonValue`, and `JsonArray` from kibanaUtils and then re-exported them. Remove the re-export from the infra plugin and instead always import these types from kibanaUtils.
smith
added a commit
that referenced
this pull request
Jan 15, 2021
The alerts plugin was importing `JsonObject` from the infra plugin. The infra plugin imported `JsonObject`, `JsonValue`, and `JsonArray` from kibanaUtils and then re-exported them. Remove the re-export from the infra plugin and instead always import these types from kibanaUtils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alerts plugin was importing
JsonObjectfrom the infra plugin. The infra plugin importedJsonObject,JsonValue, andJsonArrayfrom kibanaUtils and then re-exported them.Remove the re-export from the infra plugin and instead always import these types from kibanaUtils.
References #80508. References #81003.