Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Spaces, Security and EncryptedSavedObjects plugins to separate TS projects #88365

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Move Spaces, Security and EncryptedSavedObjects plugins to separate TS projects #88365

merged 2 commits into from
Jan 15, 2021

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Jan 14, 2021 •
edited
Loading

Summary

This PR makes the following changes:

  • Makes Spaces plugin a separate TS project
  • Makes Security plugin a separate TS project
  • Makes EncryptedSavedObjects plugin a separate TS project
  • Removes currently broken/not-used "secure space" messaging (as a separate commit, will be fixed in the scope of Restore "Secure Spaces" messaging #88368).

Metrics

Metrics captured with node --max-old-space-size=8192 ./node_modules/.bin/tsc -p x-pack/tsconfig.json --extendedDiagnostics --noEmit

  • master branch
Files:                        18723
Lines:                      2171001
Nodes:                      7677155
Identifiers:                2372457
Symbols:                    5644745
Types:                      2828020
Instantiations:             6097348
Memory used:               4683796K
Assignability cache size:    849139
Identity cache size:          40961
Subtype cache size:           96342
Strict subtype cache size:   157526
I/O Read time:                1.09s
Parse time:                  12.95s
ResolveModule time:           6.27s
ResolveTypeReference time:    0.22s
Program time:                25.44s
Bind time:                    7.40s
Check time:                 141.10s
printTime time:               0.01s
Emit time:                    0.01s
Total time:                 173.95s
  • this PR
Files:                        17892
Lines:                      2052615
Nodes:                      7234226
Identifiers:                2226856
Symbols:                    5245653
Types:                      2710185
Instantiations:             5830933
Memory used:               5087776K
Assignability cache size:    801491
Identity cache size:          35860
Subtype cache size:           88659
Strict subtype cache size:   154330
I/O Read time:                0.84s
Parse time:                  10.02s
ResolveModule time:           4.80s
ResolveTypeReference time:    0.19s
Program time:                19.83s
Bind time:                    6.40s
Check time:                 122.45s
printTime time:               0.01s
Emit time:                    0.01s
Total time:                 148.69s

@azasypkin azasypkin added 8.0.0 chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.12.0 labels Jan 14, 2021
This was referenced Jan 14, 2021
Closed
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
spaces 238 236 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
spaces 292.0KB 288.5KB -3.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin marked this pull request as ready for review January 14, 2021 20:31
@azasypkin azasypkin requested a review from a team as a code owner January 14, 2021 20:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego self-requested a review January 15, 2021 13:05
legrego
legrego approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

x-pack/plugins/security/tsconfig.json
"declarationMap": true
},
"include": ["common/**/*", "public/**/*", "server/**/*"],
"references": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to sort these alphabetically 🏅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit it becomes an obsession for me 🙈

@azasypkin azasypkin merged commit 1bd4086 into elastic:master Jan 15, 2021
@azasypkin azasypkin deleted the issue-xxx-ts-projects branch January 15, 2021 13:55
azasypkin added a commit to azasypkin/kibana that referenced this pull request Jan 15, 2021
@azasypkin
Move Spaces, Security and EncryptedSavedObjects plugins to separate T…
cba5650 
…S projects (elastic#88365)

# Conflicts:
#	x-pack/tsconfig.json
@azasypkin azasypkin mentioned this pull request Jan 15, 2021
Merged
@azasypkin
Copy link
Member Author

7.x/7.12.0: dd20886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azasypkin @kibanamachine @elasticmachine @mshustov @legrego