Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix Timeline event details layout #88377

Merged
merged 4 commits into from
Jan 15, 2021
Merged

[Security Solution] Fix Timeline event details layout #88377

merged 4 commits into from
Jan 15, 2021

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Jan 14, 2021 •
edited
Loading

Summary

The event details table is being cut off at the bottom and the horizontal bar is not visible.

Before:
image

After:
image

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team 8.0.0 labels Jan 14, 2021
@patrykkopycinski patrykkopycinski self-assigned this Jan 14, 2021
@patrykkopycinski patrykkopycinski requested review from a team as code owners January 14, 2021 17:33
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Creates a timeline.Timelines Creates a timeline

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 19 times on tracked branches: https://github.com/elastic/kibana/issues/79389

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="description"]`, but never found it.
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/timeline_creation.spec.ts:15055:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +26.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM mentioned this pull request Jan 15, 2021
Closed
@patrykkopycinski patrykkopycinski merged commit 208c768 into elastic:master Jan 15, 2021
@patrykkopycinski patrykkopycinski deleted the patrykkopycinski-patch-1 branch January 15, 2021 19:00
This was referenced Jan 15, 2021
Merged
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jan 15, 2021
@patrykkopycinski
[Security Solution] Fix Timeline event details layout (elastic#88377)
a6cd895
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jan 15, 2021
@patrykkopycinski
[Security Solution] Fix Timeline event details layout (elastic#88377)
947b675
patrykkopycinski added a commit that referenced this pull request Jan 15, 2021
@patrykkopycinski
[Security Solution] Fix Timeline event details layout (#88377) (#88512)
190f35f
patrykkopycinski added a commit that referenced this pull request Jan 15, 2021
@patrykkopycinski
[Security Solution] Fix Timeline event details layout (#88377) (#88511)
0d7e389
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 18, 2021
@gmmorris
Merge branch 'master' into tm/cancel-expired-tasks-on-hung-tm
1ded8b6 
* master: (33 commits)
  [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311)
  [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420)
  Fix log msg (elastic#88370)
  [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600)
  removing kibana-core-ui from codeowners (elastic#88111)
  [Alerting] Migrate Event Log plugin to TS project references (elastic#81557)
  [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413)
  Porting fixes 1 (elastic#88477)
  [APM] Explicitly set environment for cross-service links (elastic#87481)
  chore(NA): remove mocha junit ci integrations (elastic#88129)
  [APM] Only display relevant sections for rum agent in service overview (elastic#88410)
  [Enterprise Search] Automatically mock shared logic files (elastic#88494)
  [APM] Disable Create custom link button on Transaction details page for read-only users
  [Docs] clean-up vega map reference documenation (elastic#88487)
  [Security Solution] Fix Timeline event details layout (elastic#88377)
  Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914)
  [Monitoring] Change cloud messaging on no data page (elastic#88375)
  [Uptime] clear ping state when PingList component in unmounted (elastic#88321)
  [APM] Consistent terminology for latency and throughput (elastic#88452)
  fix copy (elastic#88481)
  ...
JasonStoltz pushed a commit to JasonStoltz/kibana that referenced this pull request Jan 19, 2021
@patrykkopycinski @JasonStoltz
[Security Solution] Fix Timeline event details layout (elastic#88377)
b72e440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrykkopycinski @kibanamachine @michaelolo24