Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flights sample data dashboard visualization #89460

Merged
merged 7 commits into from
Jan 29, 2021
Merged

Fix flights sample data dashboard visualization #89460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1593102
Fix flights sample data dashboard visualization saved search row coun…
TinaHeiligers Jan 27, 2021
45ee526
Merge branch 'master' into FT-failures/homepage-sample-data-db
kibanamachine Jan 27, 2021
05c869c
rewrite savedSearchRowCount expectation
TinaHeiligers Jan 27, 2021
4ffe335
Reverts changes, comments out failing expectation
TinaHeiligers Jan 28, 2021
595950a
Sets discover searchFieldsFromSource config flag to true
TinaHeiligers Jan 28, 2021
80c5092
Clean up config settings after test suite
TinaHeiligers Jan 28, 2021
7cf0542
Try test without setting discover search field
TinaHeiligers Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/functional/apps/discover/_data_grid_doc_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.common.navigateToApp('discover');
});

after(async function () {
log.debug('reset uiSettings');
await kibanaServer.uiSettings.replace({});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for cleaning, this up!

});

it('should show the first 50 rows by default', async function () {
// with the default range the number of hits is ~14000
const rows = await dataGrid.getDocTableRows();
Expand Down
3 changes: 1 addition & 2 deletions test/functional/apps/home/_sample_data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const dashboardExpect = getService('dashboardExpect');
const PageObjects = getPageObjects(['common', 'header', 'home', 'dashboard', 'timePicker']);

// Failing: See https://github.com/elastic/kibana/issues/89379
describe.skip('sample data', function describeIndexTests() {
describe('sample data', function describeIndexTests() {
before(async () => {
await security.testUser.setRoles(['kibana_admin', 'kibana_sample_admin']);
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
Expand Down