-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove environment from uiFilters #89647
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
4d5504d
more stuff
smith 16340c1
Merge branch 'master' into nls/env-filters
kibanamachine b10a147
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 1dbb29f
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 89eb2e1
more
smith 7a49a46
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 99a7f8e
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 90b8d37
more envs
smith 3f0ef1a
instances chart
smith 026d244
more
smith d08efb0
more more more
smith 3bfdf61
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 4f3e736
break some things
smith 9d33889
remove env check
smith bfaa207
remove setup changes
smith ad1df2a
break some things
smith 2d1fd23
range filter
smith dd2c052
queries
smith cc7b6c5
some fixes
smith 6d134a9
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 9a3c1f2
Fix service map
smith 1680ae4
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 1523d21
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 0f64561
fix at timestamp
smith 443c35c
change another timestamp
smith b98e343
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith c3d98e8
remove import
smith cab21b9
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 0ada574
Test fixes
smith cf54bc0
Merge branch 'master' into nls/env-filters
kibanamachine 355adaa
Merge branch 'master' into nls/env-filters
kibanamachine fd34ed1
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 33457aa
Merge remote-tracking branch 'upstream/master' into nls/env-filters
smith 96edb6c
fixes
smith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { SERVICE_ENVIRONMENT } from '../elasticsearch_fieldnames'; | ||
import { ENVIRONMENT_NOT_DEFINED } from '../environment_filter_values'; | ||
import { environmentQuery } from './queries'; | ||
|
||
describe('environmentQuery', () => { | ||
describe('when environment is undefined', () => { | ||
it('returns an empty query', () => { | ||
expect(environmentQuery()).toEqual([]); | ||
}); | ||
}); | ||
|
||
it('creates a query for a service environment', () => { | ||
expect(environmentQuery('test')).toEqual([ | ||
{ | ||
term: { [SERVICE_ENVIRONMENT]: 'test' }, | ||
}, | ||
]); | ||
}); | ||
|
||
it('creates a query for missing service environments', () => { | ||
expect(environmentQuery(ENVIRONMENT_NOT_DEFINED.value)[0]).toHaveProperty( | ||
['bool', 'must_not', 'exists', 'field'], | ||
SERVICE_ENVIRONMENT | ||
); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a better name 👍